Problem/Motivation

The font-size of the heading text and body text should be updated. Font sizes of the heading and body text are not for mobile devices

Steps to reproduce

Proposed resolution

Change the font sizes for Heading text 28px while body text is 16px

CommentFileSizeAuthor
#3 --bs-gutter-x = 0.png1.1 MBkenyoowen
#3 row class.png1.05 MBkenyoowen
#3 scrollable to right.png793.78 KBkenyoowen
image-20231115-221144.png940.31 KBkenyoowen

Issue fork provus-3408960

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kenyoOwen created an issue. See original summary.

kenyoowen’s picture

kenyoowen commented
Title: Header and body text of the mobile devices should be updated » Large banner header and body text of the mobile devices should be updated
kenyoowen’s picture

kenyoowen commented
Status: Active » Needs work
StatusFileSize
new scrollable to right.png793.78 KB
new row class.png1.05 MB
new --bs-gutter-x = 0.png1.1 MB

UPDATE:

After fixing the header and body text font sizes, I couldn't fix the scrollable to the right on the mobile device. And checked the cause of the scrollable to right and noticed that the row class and the code line is --bs-gutter-x: 1.5rem; is the reason for it. And by changing --bs-gutter-x to 0 will fix the scrollable to right but it will have an issue with margining in any components that used row class. Please see the screenshot for reference.

Thank you.

kenyoOwen opened merge request !93

aastrong’s picture

aastrong commented

Hey guys, I have a much easier fix for the issues with the scrolling horizontally.
Try this instead:

html {
  overflow-x: hidden;
}

I dont want to change the padding on rows, containers or columns unless we need to
For the issues with the font size, your MR looks good.

kenyoowen’s picture

kenyoowen commented
Status: Needs work » Needs review

The scrollable to right issue is fixed, thanks to aastrong.

kenyoowen’s picture

kenyoowen commented
Assigned: kenyoowen » Unassigned
kenyoowen’s picture

kenyoowen commented

This is ready for review, I also included the fixes for the following Drupal.org issue since they are all related. I close also the MR for the related issue.

https://www.drupal.org/project/provus/issues/3409393

Thank you

kenyoowen’s picture

kenyoowen commented
Assigned: Unassigned » kenyoowen
Status: Needs review » Needs work

I'll be creating a new branch since Tugboat isn't working right now. And will fix the issue raised by QA.

kenyoOwen opened merge request !101

kenyoOwen changed the visibility of the branch 3408960-header-and-body to hidden.

kenyoOwen closed merge request !93

kenyoowen’s picture

kenyoowen commented
Assigned: kenyoowen » Unassigned
Status: Needs work » Needs review

This is now ready for retest. Will send to QA now. Closing MR!93 tugboat not working .

kenyoowen’s picture

kenyoowen commented

Hi,

Will send this to QA later when the tugboat is stable. Right now, the tugboat is loading and Bad Gateway text will appear.

nx2611’s picture

nx2611 commented
Status: Needs review » Fixed
nx2611’s picture

nx2611 commented
Status: Fixed » Closed (fixed)