Problem/Motivation
@finnsky has been instrumental in several major improvements to the umami profile. Most of the components that have been converted to SDC have been completed by him almost single-handedly.
#3390334: Create new Badge component for recipe
#3378588: Convert Umami's node.html.twig to use SDC components
#3365497: Create new SDC component for Umami Banner
#3390344: Create new List component for Umami
#3397532: Fix Umami container max-width when toolbar or navigation expanded.
It would be great to have someone with so much knowledge of how SDC works in Umami as a maintainer of Umami before SDC becomes stable in Drupal core.
I've approached him and asked if he is interested in being a co-maintainer, he has said yes.
Proposed resolution
- @finnsky to confirm publicly and confirm that:
- He has read the Drupal core governance, including especially How decisions are made.
- He understands the high-level description of maintainers and is comfortable with it.
- He is committed to providing constructive feedback as defined in the issue etiquette documentation.
- patch/MR to maintainers.txt
- review
- rtbc
- commit
- update maintainers on node/3060
Remaining tasks
As above
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | Снимок экрана 2023-12-21 в 10.56.05.png | 29.14 KB | kostyashupenko |
Issue fork drupal-3408849
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 11.x
changes, plain diff MR !5902
- 3408849-add-finnsky-as
changes, plain diff MR !5901
Comments
Comment #2
markconroy commentedComment #3
markconroy commentedComment #4
larowlan+1 - he's also been doing great work with the admin UI initiative and jQuery removal
Keep up the good work 💪
Comment #5
finnsky commentedThanks for all!
I'm glad to be part of the community, and I hope that I can continue everything we started in your wonderful company!
Comment #6
finnsky commentedI confirm that I have read and understood all the necessary documentation.
Comment #10
shaal+1
@finnsky is doing fantastic work! thank you
Comment #11
ckrina+1
Beyond his great work he's also shown a really constructive attitude on issue interactions, both giving and receiving feedback, on the Navigation and other related admin UI issues.
Comment #12
kostyashupenko+1 for Vanya

No words, just screenshot from my d.org profile !
Comment #13
gaydabura commented+1
Comment #14
catch+1 too, but the best kind of +1 is marking the issue RTBC and this still seems to be active despite having an MR.
Comment #15
alexpottCommitted and pushed a99ed6d2d0 to 11.x and f4f3108294 to 10.3.x and 2a4f67ca71 to 10.2.x. Thanks!