Problem/Motivation

@finnsky has been instrumental in several major improvements to the umami profile. Most of the components that have been converted to SDC have been completed by him almost single-handedly.

#3390334: Create new Badge component for recipe
#3378588: Convert Umami's node.html.twig to use SDC components
#3365497: Create new SDC component for Umami Banner
#3390344: Create new List component for Umami
#3397532: Fix Umami container max-width when toolbar or navigation expanded.

It would be great to have someone with so much knowledge of how SDC works in Umami as a maintainer of Umami before SDC becomes stable in Drupal core.

I've approached him and asked if he is interested in being a co-maintainer, he has said yes.

Proposed resolution

  1. @finnsky to confirm publicly and confirm that:
  2. patch/MR to maintainers.txt
  3. review
  4. rtbc
  5. commit
  6. update maintainers on node/3060

Remaining tasks

As above

Issue fork drupal-3408849

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

markconroy created an issue. See original summary.

markconroy’s picture

Issue summary: View changes
markconroy’s picture

Issue summary: View changes
larowlan’s picture

+1 - he's also been doing great work with the admin UI initiative and jQuery removal

Keep up the good work 💪

finnsky’s picture

Thanks for all!
I'm glad to be part of the community, and I hope that I can continue everything we started in your wonderful company!

finnsky’s picture

I confirm that I have read and understood all the necessary documentation.

shaal’s picture

+1
@finnsky is doing fantastic work! thank you

ckrina’s picture

+1

Beyond his great work he's also shown a really constructive attitude on issue interactions, both giving and receiving feedback, on the Navigation and other related admin UI issues.

kostyashupenko’s picture

+1 for Vanya
No words, just screenshot from my d.org profile !
test

gaydabura’s picture

+1

catch’s picture

Status: Active » Reviewed & tested by the community

+1 too, but the best kind of +1 is marking the issue RTBC and this still seems to be active despite having an MR.

alexpott’s picture

Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed a99ed6d2d0 to 11.x and f4f3108294 to 10.3.x and 2a4f67ca71 to 10.2.x. Thanks!

  • alexpott committed 2a4f67ca on 10.2.x
    Issue #3408849 by markconroy, finnsky: Add @finnsky as core maintainer...

  • alexpott committed f4f31082 on 10.3.x
    Issue #3408849 by markconroy, finnsky: Add @finnsky as core maintainer...

  • alexpott committed a99ed6d2 on 11.x
    Issue #3408849 by markconroy, finnsky: Add @finnsky as core maintainer...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.