Problem/Motivation

In the Status Report on Drupal 10.1.6 the following error is shown:

The following embed button(s) are not using SVG icons and will not be compatible with CKEditor5
File Browser: /files/file_browser_icon.png

Proposed resolution

Provide an SVG version of the icon
(optional) Use the SVG version by default
(optional) Write an update hook to switch from the PNG to the SVG

CommentFileSizeAuthor
#2 3406488-2.patch990 bytesjofitz

Issue fork file_browser-3406488

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jofitz created an issue. See original summary.

jofitz’s picture

jofitz
he/him
commented
Assigned: jofitz » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3406488-2.patch990 bytes

Add an SVG icon

cchiste’s picture

cchiste commented

Works well on Drupal 11.1

d.fisher’s picture

d.fisher commented
Version: 8.x-1.x-dev » 2.x-dev

Changing the target version and creating a branch to test.

d.fisher opened merge request !7

d.fisher’s picture

d.fisher commented

Thank you for this. I've wrapped this into a branch with a merge request attached.

Forgive my ignorance but how to we use the SVG version by default? And if we write an update hook to switch from the PNG to the SVG where does the module need switching? Definitely sounds sensible but not 100% sure I understand where this needs implementing?

d.fisher’s picture

d.fisher commented

Be good to get this one sorted!

I just need clarity around these two items from OP (jofitz):
(optional) Use the SVG version by default
(optional) Write an update hook to switch from the PNG to the SVG

Is there a specific way to use the SVG by default and what parts of the module should the update hook be targeting?

jofitz’s picture

jofitz
he/him
commented

I'm sorry @d.fisher, it has been so long that I can't remember

d.fisher’s picture

d.fisher commented

Okay I think I might have it!

d.fisher’s picture

d.fisher commented

Jeepers. I think that's it. Can you test?

d.fisher’s picture

d.fisher commented

Here's the url for composer patches:
https://git.drupalcode.org/project/file_browser/-/merge_requests/7.patch

d.fisher’s picture

d.fisher commented

Anyone want to test this for me? If not it's working for me and I'll just merge it!

d.fisher’s picture

d.fisher commented
Status: Needs review » Reviewed & tested by the community

Guess we'll rock and roll with this as is.

  • d.fisher committed c3246fd8 on 2.x 
    Resolve #3406488 "Icon CKEditor5 compatibility"
d.fisher’s picture

d.fisher commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.