Problem/Motivation

The 'core_version_requirement' constraint (^9 || ^10) requires the 'core' key not be set in modules/contrib/tome/tome.info.yml

Steps to reproduce

Try installing this module on D9 using composer

Proposed resolution

We need to remove core key from .info.yml file as suggested here: https://www.drupal.org/node/3070687

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork tome-3406138

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Sivaji_Ganesh_Jojodae created an issue. See original summary.

chetan 11 made their first commit to this issue’s fork.

chetan 11 opened merge request !10

chetan 11’s picture

chetan 11 commented
Status: Active » Needs review

Hi,
I have fixed the above issue on "tome" module, please check the raised MR.
Thanks.

sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented
Status: Needs review » Needs work 
core_version_requirement: ^9 || ^10
chetan 11’s picture

chetan 11 commented
Status: Needs work » Needs review
sivaji_ganesh_jojodae’s picture

sivaji_ganesh_jojodae commented

I think we should remove the core and change the core_version_requirement to support only 9 & 10 (core_version_requirement: ^9 || ^10) since D8 is no longer supported anyway.

vbouchet’s picture

vbouchet
Location Toulouse
commented
Status: Needs review » Needs work

as @Sivaji_Ganesh_Jojodae, I think we should remove any mention to Drupal 8 in composer.yml or info.yml files. Also, all the sub-modules should be updated.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: Unassigned » sourabhjain

Let me work on #7

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: sourabhjain » Unassigned
Status: Needs work » Needs review
emofsnead’s picture

emofsnead commented

Please consider rolling back the recommended version to 1.11 until this issue is dealt with. That build is the only one that you can simply run directly in a Composer install without crashing and burning. Unless a user is willing to go down in and edit YML file for the info on this module they will be very frustrated trying it out. It is a really valuable tool and even important to the low end user starting out with Drupal. I just hate to see users potentially being disenfranchised by this temporary hiccup.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.x-1.12 » 8.x-1.x-dev

marcoliver made their first commit to this issue’s fork.

marcoliver’s picture

marcoliver
he/him
Primary language German
Location Neuss, NRW, Germany
commented
Status: Needs review » Reviewed & tested by the community

Merged-in the latest 8.x-1.x commits.

MR looks good to me, since 8.x-1.12 dropped support for D8, so the core key can be dropped. Marking as RTBC.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs work

No longer applies

marcoliver’s picture

marcoliver
he/him
Primary language German
Location Neuss, NRW, Germany
commented
Status: Needs work » Needs review

Updated the MR against the latest 8.x-1.x to resolve conflicts

joseph.olstad made their first commit to this issue’s fork.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: The 'core_version_requirement' constraint (^9 || ^10) requires the 'core' key not be set » Drop the core key and drop support for D8 and D9.

joseph.olstad changed the visibility of the branch 3406138-the-coreversionrequirement-constraint to hidden.

joseph.olstad opened merge request !37

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Reviewed & tested by the community

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x-1.x thanks folks

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

https://www.drupal.org/project/tome/releases/8.x-1.14

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.