Problem/Motivation
The configure link missing for the module on the "/admin/modules" page.
Steps to reproduce
Enable the "Automatic Updates" module.
Proposed resolution
Add configure link in the .info.yml file.
Remaining tasks
Adding code to the module's info.yml file. Either it should take to the "/admin/reports/updates/settings" page or "/admin/reports/updates" page.
Along with this the "Automatic Updates Extensions" should also have the configure link to its settings page which is available at "/admin/reports/updates/automatic-update-extensions"
User interface changes
NA
API changes
NA
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #31 | automatic_updates-after-fixes.png | 24.35 KB | tirupati_singh |
| #31 | automatic_updates-before.png | 22.47 KB | tirupati_singh |
| #13 | Screenshot from 2024-04-06 14-14-45.png | 112.46 KB | vivek panicker |
| #13 | Screenshot from 2024-04-06 14-14-54.png | 109.16 KB | vivek panicker |
| #13 | Screenshot from 2024-04-06 14-17-28.png | 83.28 KB | vivek panicker |
Issue fork automatic_updates-3406122
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
prashant.cComment #6
sandipta commentedAdding patch as per problem statement
Comment #7
prashant.cComment #8
sandipta commentedAdding Patch for additional requirement
Comment #9
phenaproximaLooks like this needs a reroll.
Comment #11
gaurav gupta commentedReroll patch for version 3.0.x
Comment #13
vivek panicker commentedCode looks good.
Also requirements are fulfilled.
Hence moving to RTBC.
Comment #14
vivek panicker commentedComment #15
phenaproximaI'm not sure this patch makes sense as-is. The configure link for Automatic Updates Extensions isn't really a configuration page, so...why is it there? Can you explain the rationale for pointing it to that specific route?
Comment #16
gaurav gupta commented@phenaproxima
Yes, I agree since Automatic Updates Extensions does not have any configuration form we can skip this.
Made the changes.
Thanks
Comment #17
phenaproximaTests appear to be failing...?
Comment #18
gaurav gupta commented@phenaproxima
I am not sure if i have made changes that made pipeline failed.
All i have done is solve conflicts and revert some changes.
Thanks.
Comment #19
anybodyTests are failing because this targets the wrong branch. The fork needs to be updated so that the 3.1.x branch becomes available as merge target.
Comment #24
prashant.cRebased with
3.1.xLets see the tests pass or not.Comment #25
prashant.cComment #28
prashant.cThere were a lot of out-of-scope changes in the previously raised MRs, raised a new one, and made others hidden. Once the tests pass we can change the issue status to NR
Comment #29
prashant.cComment #30
gaurav gupta commentedComment #31
tirupati_singh commentedHi, I've applied the provided MR as a patch and it applied cleanly with no errors. Before applying patch there was no Configuration link for the module on the Extend page
/admin/modules. On applying the patch, module configuration link is now added on the Extend page andadmin/reports/updates/settingspage opens when clicking on the Configure link. I've attached the before and after screenshots for reference.Thanks!
Comment #32
sourav_paulYeah, MR !1090 works for me as well.
It attached a configure link to the module on the extend page.
RTBC+1
Comment #33
phenaproximaComment #34
phenaproximaComment #36
phenaproximaMerged into 3.1.x, thanks!