Problem/Motivation

D10 compatibility amend.

Steps to reproduce

Make a request to the epub_reader_framework.node_ajax_view route.

Proposed resolution

in ReaderNodeAjaxController, switch $event and $event_name parameters being passed to ContainerAwareEventDispatcher::dispatch() so that $event is passed in the first position.

$event_dispatcher->dispatch($event, $event_name);

This method is also used in ReaderEpubXhtmlConverter but the signature appears with the event in the first position there.

Issue fork epub_reader_framework-3406027

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

JoshHytr created an issue. See original summary.

JoshHytr opened merge request !3

joshhytr’s picture

joshhytr commented
Status: Active » Needs review

scott_euser made their first commit to this issue’s fork.

scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Great thanks! I am going to merge this into dev and test more thoroughly with your merge requests combined

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.