Problem/Motivation

Extra sidebar was added on LB compatible pages after update to D10

The root of the issue - social_core.layout service doesn't run on Drupal 10

Steps to reproduce

Open any Dashboard or Organization page and their LB on Drupal 10

Proposed resolution

Change the code with alternative in /src/Plugin/Preprocess/Page.php

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#18 3405919-2.patch3.9 KBluckie joe
#16 3405919-1.patch3.83 KBluckie joe
#5 190.diff3.76 KBluckie joe
bug.png590.25 KBluckie joe

Issue fork socialbase-3405919

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Luckie Joe created an issue. See original summary.

Luckie Joe opened merge request !190

luckie joe’s picture

luckie joe commented
Status: Active » Needs review
luckie joe’s picture

luckie joe commented

Related ticket - https://getopensocial.atlassian.net/browse/PROD-27484

luckie joe’s picture

luckie joe commented
StatusFileSize
new 190.diff3.76 KB

  • ribel committed c4282ab5 on 2.5.x authored by Luckie Joe 
    Issue #3405919: social_core.layout service doesn't run on Drupal 10
ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Status: Needs review » Reviewed & tested by the community

Changes were tested and worked as expected.
PR was merged into the 2.5.x branch and will be included in the next release.

viniciusrp’s picture

viniciusrp commented
Status: Reviewed & tested by the community » Fixed

That fixed will be released at 2.5.11.

viniciusrp’s picture

viniciusrp commented
ronaldtebrake’s picture

ronaldtebrake commented

Hey all, I had to revert this.
In the Distro you would get: 

Fatal error: Trait "Drupal\layout_builder\LayoutEntityHelperTrait" not found in /var/www/html/themes/contrib/socialbase/src/Plugin/Preprocess/Page.php on line 25

Because that's not something we install with the Distro (or with core) by default, it's a contrib module. So we can't do it in the current form.

ronaldtebrake’s picture

ronaldtebrake commented
Status: Fixed » Needs work

  • ronaldtebrake committed 97cd33ab on 2.5.x 
    Revert "Issue #3405919: social_core.layout service doesn't run on Drupal...
ronaldtebrake’s picture

ronaldtebrake commented

https://git.drupalcode.org/project/socialbase/-/merge_requests/194

Luckie Joe opened merge request !196

luckie joe’s picture

luckie joe commented

PR - https://git.drupalcode.org/project/socialbase/-/merge_requests/196

luckie joe’s picture

luckie joe commented
StatusFileSize
new 3405919-1.patch3.83 KB
ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Status: Needs work » Needs review
luckie joe’s picture

luckie joe commented
StatusFileSize
new 3405919-2.patch3.9 KB
ribel’s picture

ribel
Primary language Ukrainian
Location 🇺🇦Lviv
commented
Status: Needs review » Reviewed & tested by the community

New changes were tested and looks good to me

agamich’s picture

agamich commented
Assigned: luckie joe » Unassigned
Status: Reviewed & tested by the community » Fixed

Merged into the 2.5.x branch

Agami4 changed the visibility of the branch 3405919-socialcore.layout-service-doesnt to hidden.

  • Agami4 committed e7d2e4ad on 2.5.x authored by Luckie Joe 
    Issue #3405919: call service 'social_core.layout' via \Drupal::service()

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

agamich’s picture

agamich commented
Version: 2.5.x-dev » 2.5.13