Problem/Motivation

Similar to 3400324, another PHP 8 compatibility issue.

TypeError: Unsupported operand types: string / int in csl_number->ordinal() (line 1373 of /var/www/html/web/sites/all/modules/biblio/modules/CiteProc/CSL.inc).

Steps to reproduce

In my case, it happened when using biblio with views_data_export, when I try to download the CSV, I get WSOD.

Proposed resolution

Force casting $num into an integer.

CommentFileSizeAuthor
#3 typeerror-unsupported-operand-types-string-int-in-cslnumber-ordinal-3404776-2.patch400 bytesjordan.jamous

Issue fork biblio-3404776

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jordan.jamous created an issue. See original summary.

jordan.jamous’s picture

jordan.jamous commented

The patch

jordan.jamous’s picture

jordan.jamous commented
StatusFileSize
new typeerror-unsupported-operand-types-string-int-in-cslnumber-ordinal-3404776-2.patch400 bytes

Trying again

jordan.jamous opened merge request !9

jordan.jamous changed the visibility of the branch 3404776-typeerror-unsupported-operand to hidden.

jordan.jamous changed the visibility of the branch 3404776-typeerror-unsupported-operand to hidden.

jordan.jamous changed the visibility of the branch 3404776-typeerror-unsupported-operand to active.

jordan.jamous’s picture

jordan.jamous commented
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Is the merge request ready? In which case, please mark it not a draft.

jordan.jamous’s picture

jordan.jamous commented

@liam-morland Done, thanks.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.