Problem/Motivation

3.x added a few config settings, but it seems that the config schema wasn't (fully) updated. Also, the now obsolete auto_show setting (to be removed in update hook 10001) is still present in klaro.settings.yml so would be added for new installs.

Steps to reproduce

Install the contributed config_inspector module and look at the report for klaro.settings config object.

Proposed resolution

- Add config schema where missing (except for auto_show).
- Remove auto_show from default settings.
- Add new update hook to remove auto_show from config for new installations.

Remaining tasks

User interface changes

None.

API changes

None

Data model changes

Remove auto_show from klaro.settings config object.

CommentFileSizeAuthor
#3 3404691-03.patch1.69 KBfeyp
#2 3404691-02.patch1.69 KBfeyp

Issue fork klaro-3404691

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

FeyP created an issue. See original summary.

feyp’s picture

Assigned: feyp » Unassigned
Status: Active » Needs review
StatusFileSize
new1.69 KB

Quick patch against 3.x-dev. Ideally, since we're already add an update hook anyway, the integer settings that are really boolean would be convered to boolean in the schema and the config object and then saved as boolean by the settings form, but I didn't add that due to time constraints.

feyp’s picture

StatusFileSize
new1.69 KB

Doh, the strings for unknown block label and description should be translatable, so it should be type label, not type string. New patch attached. No interdiff since it's trivial.

sascha_meissner made their first commit to this issue’s fork.

sascha_meissner’s picture

Thank you very much, merged into 3.x and part of next RC!

sascha_meissner’s picture

Status: Needs review » Fixed

Released with 3.0.0-rc6

sascha_meissner’s picture

Status: Fixed » Closed (fixed)