Problem/Motivation

The <aside> element currently does not have a region label, so a rotor would see this as "complementary". A label would make this more useful, and in instances where the toolbar is on a page with an additional unlabeled <aside>, prevent an accessibility bug

The landmarks within the toolbar are labeled "Content" and "Administrative toolbar footer". A label that better describes the content and/or purpose of this region would benefit navigation.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork navigation-3403423

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Parent issue: » #3391723: [PLAN] Accessibility review for new Navigation bar

Adding parent issue.

Prashant.c made their first commit to this issue’s fork.

Prashant.c opened merge request !155

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Active » Needs review

Implemented a label for the aside section, but it is recommended to review the text. Additionally, consider finalizing labels for the nav sections with "content" having id="menu-builder" and "footer" having id="menu-footer".

Your review is appreciated. Thank you.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Needs work

Gauravvvv made their first commit to this issue’s fork.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

m4olivei made their first commit to this issue’s fork.

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented

I reviewed this a bit with VoiceOver on Mac, paying particular attention to the Landmarks and Headings Rotor menus. I made some changes. I think this gets us better to solving the intent of the ticket, describing the toolbar and the various parts more throughly.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Fixed

Reviewed and merged! Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.