Problem/Motivation

From a Slack discussion about #3337513-77: Fix batch process race conditions by making ‘bid (batch id)’ auto-increment. Participants were berdir, moshe and xjm.

The summary of the discussion was that berdir pointed out that "the problem is fairly severe imho, drush updb is broken". The solution was that moshe would make a new drush release and that core would update the drush conflict to "<12.4.3".

Steps to reproduce

Proposed resolution

Update core composer.json drush conflict to "<12.4.3"

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Drush versions below 12.4.3 are incompatible with Drupal 10.2.0 and above. If you use Drush, you will need to upgrade to 12.4.3 or greater.

Issue fork drupal-3402955

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !5484

quietone’s picture

quietone commented
Priority: Normal » Critical
spokje’s picture

spokje
Primary language Dutch
commented

https://github.com/drush-ops/drush/releases/tag/12.4.3 is released.

I think this is the bug the conversation was about: https://github.com/drush-ops/drush/issues/5797 which is fixed in this PR https://github.com/drush-ops/drush/pull/5809 and is included in the release mentioned above.

The MR here does bump the "conflict": to "drush/drush": "<12.4.3", so that's fine.

I would RTBC, but this issues is still on active (as I just realized) instead of NR.
Just wanted to leave my findings in here.

quietone’s picture

quietone commented
Status: Active » Needs review

@Spokje, thanks for adding the details in your comment. And for pointing out the incorrect status! Setting to NR

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

And RTBC based on #4.

EDIT: Seeing this "forces" drush users to update, since all older versions are now in conflict with core, this should probable have a release note and/or CR?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes
Issue tags: +10.2.0 release notes

Added a change record and release note snippet.

  • longwave committed 961cc15c on 10.2.x 
    Issue #3402955 by quietone, Spokje: Update drush conflict to "<12.4.3"

  • longwave committed 7cb99a11 on 11.x 
    Issue #3402955 by quietone, Spokje: Update drush conflict to "<12.4.3"
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Fixed

Committed to 11.x and 10.2.x. Also published the change record. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 11.x-dev » 10.2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone closed merge request !5484

xjm credited berdir.

xjm credited moshe weitzman.

xjm’s picture

xjm
she/her
Primary language English
commented

I remember this. Adding Slack discussion participants.