Problem/Motivation

I was trying to get this set up, but there was no documentation provide (not even a README) that had the specifications for required settings.php settings.

Steps to reproduce

Proposed resolution

After reviewing the module code, it would appear you just need to include something in the README and on your drupal.org documentation page(s) that provides a simple template of what's required:

$settings['o365'] = [
'api_settings' => [
'client_id' => '',
'client_secret' => '',
'tenant_id' => '',
],
];

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 issues-3402937-Added-required-documentation-for-this-module.patch690 bytesviren18febs

Issue fork o365-3402937

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mausolos created an issue. See original summary.

viren18febS made their first commit to this issue’s fork.

viren18febs’s picture

viren18febs commented
Status: Active » Needs review
StatusFileSize
new issues-3402937-Added-required-documentation-for-this-module.patch690 bytes

Hi @mausolos
I have added the following line in README file, added a patch please review
Thanks

mausolos’s picture

mausolos commented

Sweet, hopefully this helps someone :)

Thank you!

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
commented
Issue tags: +finalist-sprint

  • fabianderijk committed 1419a251 on 5.0.x 
    Issue #3402937 by viren18febS, batigolix: There are no API settings...
fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented

Thanks for the patch. I've applied it and changed it a bit. This is now available in the dev release.

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.