Problem/Motivation

Add .gitlabl-ci.yml file from gitlab_templates, to get the pipeline tests running.

Issue fork module_filter-3402091

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055 opened merge request !31

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review

The basic gitlab-ci.yml file works. I have set eslint, stylelint and phpcs to have allow_failure: false so that we can easily see what is wrong. I think this is OK in the first instance. Ready for review and commit. Then we can get the other issues running on pipelines to see how they go.

jonathan1055’s picture

jonathan1055 commented

The phpunit pipeline job fails in the pipeline but passes OK on drupalCI. That will need some investigation, but should not stop the gitlab-ci file from being committed.

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Will address the eslint findings in the javascript tickets.

Will need a follow up for the failing tests.

jonathan1055’s picture

jonathan1055 commented
Related issues: +#3402384: testUninstallPageFiltering fails in Gitlab pipeline

Created #3402384: testUninstallPageFiltering fails in Gitlab pipeline for the failing phpunit test

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.