One javascript test fails in the new gitlab pipeline tests. This does not fail in DrupalCI.
The test is FunctionalJavascript\ModuleFilterJavascriptUninstallPageTest::testUninstallPageFiltering

Log https://git.drupalcode.org/project/module_filter/-/jobs/349380#L47

Issue fork module_filter-3402384

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055 opened merge request !33

jonathan1055’s picture

jonathan1055 commented

I think the reason this fails on gitlab is that the core uninstall form does not yet have
$form['#attached']['library'][] = 'core/drupal.tableresponsive';

We added this, as a patch in drupalci.yml. So need to do the same for GitLabCI.

The core isssue #3331975: Uninstall form does not add drupal.tableresponsive library is closed as a dupliacte because that fix was added to #2895388: Modules uninstall filter does not filter by machine name. But we can still use the patch from the closed issue, as that is just a one-line change so safer to do.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review

Pipeline phpunit passes green now.
Also set eslint to be a warning not failure, so that the pipeline result is amber not red.
Ready for review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Excellent find!

jonathan1055’s picture

jonathan1055 commented

Thanks. Odd coincidence because I found the problem, went to that issue then saw your comment asking me to update the MR for core 11.x. I will try to do that soon.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.