Problem/Motivation

MariaDB 10.3.22 conf/setup.sql creates a user that already exists when the image is spin up in GitlabCI. That causes the container not to run and make tests fail (check parent issue).

I've tested this building a local image of drupalci:mariadb10.3.22 and using this for gitlab-ci-local in parent's MR code

Steps to reproduce

Proposed resolution

Remove the first line "CREATE USER ..." from "db/mariadb-10.3.22/conf/setup.sql"

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupalci_environments-3399858

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • dev Comparechanges, plain diff MR !30
About issue forks

Comments

dimitriskr created an issue. See original summary.

dimitriskr’s picture

dimitriskr commented
Title: MariaDB 10.3.22 setup.sql creates a user that exists » MariaDB 10.3.22 setup.sql creates a user that already exists
Issue summary: View changes

dimitriskr opened merge request !30

fjgarlin’s picture

fjgarlin commented

I see that the approach taken in the "mysql" images is different, where the commands to create the user and flush priviledges is done in the startup.sh script. "mariadb" images follow a different approach, so I wonder if the user is created at all.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Let's unify the approach, I think pgsql images makes sense to check as well as they were the last anybody touch

dimitriskr’s picture

dimitriskr commented

Core tests still pass with the new approach.
As discussed in a Slack thread, no changes will take place at MariaDB 10.2 version yet

fjgarlin’s picture

fjgarlin commented

@dimitriskr - is this ready for review or are you planning to do some more work here?

dimitriskr’s picture

dimitriskr commented
Status: Active » Needs review

Ah sorry, yeap, it's ready for review.

fjgarlin’s picture

fjgarlin commented

The refactoring looks good to me, but probably @andypost will be better positioned to fully review and merge this.
As soon as it's merged to "dev" or "prod" images, we can test the core issue. Thanks!

dimitriskr’s picture

dimitriskr commented

@andypost, shall we unify the approaches of all DBs here on this issue, or create a follow-up?

catch’s picture

catch
he/him
Primary language English
commented

For me I think we should do the consolidation in a follow-up. This will issue will allow us to switch off more DrupalCI jobs, and bring us closer to being able to shut it down (for core testing at least) altogether.

andypost’s picture

andypost
he/him
Primary language Russian
commented

It looks good to me but I have no ability to test/merge it in next 2 days

Probably I need to squash commits via Gitlab to simplify cherry-picking to production branch

fjgarlin’s picture

fjgarlin commented

Just following up. Any update on this? If it gets merged to dev we'd be able to further review and test here #3385621: [GitlabCI] MariaDB currently not working.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Merged to dev so it can be tested as pipeline passed https://git.drupalcode.org/project/drupalci_environments/-/commit/176e3d...

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Needs work

The issue is that repository changed https://mariadb.org/download/?t=repo-config&d=18.04+LTS+%22bionic%22&v=1...

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Reviewed & tested by the community

Looks now it working https://git.drupalcode.org/issue/drupal-3385621/-/pipelines/54549

the issue hew is that the image no longer maintained(

  • andypost committed 1038da61 on production authored by dimitriskr 
    MariaDB 10.3.22 - remove "create user" statement #3399858


(cherry...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

Pushed production image https://git.drupalcode.org/project/drupalci_environments/-/jobs/387237

Core's pipeline https://git.drupalcode.org/issue/drupal-3385621/-/pipelines/54560

fjgarlin’s picture

fjgarlin commented

Big THANK YOU.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.