Add static caching in domain access

CommentFileSizeAuthor
#2 domain_static_cache.patch2.52 KBborisson_

Issue fork domain-3399596

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

borisson_ created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
StatusFileSize
new domain_static_cache.patch2.52 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: domain_static_cache.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mably’s picture

mably commented
Category: Bug report » Feature request

Could you create a MR on 2.0.x please ?

mably opened merge request !183

mably’s picture

mably commented

Entity field values could change during a single request.

How do we handle that?

EDIT: Tests rightfully catch that problem.

mably’s picture

mably commented
Status: Needs work » Needs review
mably’s picture

mably commented
Issue tags: +next-release
mably’s picture

mably commented

Hi @borisson_ could you have a look at the MR please? Thanks.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

This looks great! We've been using this patch in production for all this time and it's been working great for us so far.

mably’s picture

mably commented

Hi @borisson_, thanks a lot for your feedback.

Does it give a significant performance boost?

  • mably committed 86136008 on 2.0.x 
    Issue #3399596 by borisson_, mably: Add static caching in domain access
mably’s picture

mably commented
Status: Reviewed & tested by the community » Fixed
mably’s picture

mably commented
Issue tags: -next-release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.