Update core_version_requirement https://git.drupalcode.org/project/xbbcode/-/blob/5.0.x/xbbcode.info.yml to the double pipe (||) operator for logical OR. A single pipe still wotks, but has been deprecated. See: https://getcomposer.org/doc/articles/versions.md#version-range

Update core_version_requirement to use "||" operator for logical OR

CommentFileSizeAuthor
#5 3399511.patch382 bytessandipta

Issue fork xbbcode-3399511

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gisle created an issue. See original summary.

gisle opened merge request !7

gisle closed merge request !7

sandipta’s picture

sandipta commented
StatusFileSize
new 3399511.patch382 bytes

gisle opened merge request !8

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Active » Needs review

I've created a MR. It is identical to the patch by sandipta.It was created in parallell. Moving to "Needs review".

raveen_thakur51’s picture

raveen_thakur51 commented

@gisle, I have reviewed the MR!, Yes it was a straight forward fix. Thank You

raveen_thakur51’s picture

raveen_thakur51 commented
Status: Needs review » Reviewed & tested by the community

cburschka made their first commit to this issue’s fork.

  • cburschka committed b458299d on 5.0.x authored by gisle 
    Issue #3399511 by gisle:  Update core_version_requirement to use "||"...
cburschka’s picture

cburschka
they
commented
Status: Reviewed & tested by the community » Fixed

Thank you!

I'll check and port this change to other supported branches wherever needed. As far as I can tell, the double pipe syntax has been recommended since at least 2017, so it should be safe to do this on all versions.

  • cburschka committed cbc9e89b on 4.0.x authored by gisle 
    Issue #3399511 by gisle:  Update core_version_requirement to use "||"...
cburschka’s picture

cburschka
they
commented

Cherry-picked and pushed to 4.0.x (with the appropriate version numbers).

3.0.x was D8 only (and predates core_version_requirement), so no change is needed.

6.0.x is currently marked as D10 only (I'll add D11 at some point after D11 is in beta), so for now it doesn't use a logical OR and doesn't need to be changed.

That's all :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.