Problem/Motivation

Only the flattened loader needs the template key.

Steps to reproduce

Go to site settings configuration and template key is there.

Proposed resolution

Simplest would be a method added to loader + interface indicating template key is needed, then show if the loader plugin needs template key.

Perhaps more advanced option could be Plugin Configuration to allow future plugins to provide their own settings.

No strong preference here.

Remaining tasks

Update site settings configuration.

User interface changes

Site settings configuration should only show template_key when it is applicable.

API changes

None

Data model changes

None

Issue fork site_settings-3399429

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

bobi-mel’s picture

bobi-mel commented
Assigned: Unassigned » bobi-mel
Status: Active » Needs work
bobi-mel’s picture

bobi-mel commented
Status: Needs work » Active

bobi-mel opened merge request !19

bobi-mel’s picture

bobi-mel commented
Assigned: bobi-mel » Unassigned
Status: Active » Needs review

Hi @ scott_euser
I fixed this issue
Also, I changed the order for inputs. The 'loader_plugin' input is displayed first. It looks better if changing plugins in the select list

scott_euser’s picture

scott_euser commented
Status: Needs review » Fixed

Thanks! Actually template_key is only relevant when auto-load is enabled, so I updated the code to just base it on that. Tricky part was getting the ajax and plugin check to control access working of course, glad you managed! Thanks!

  • bobi-mel committed 3c054a59 on 2.0.x 
    Issue #3399429 by bobi-mel: Hide "template_key" in site settings...
bobi-mel’s picture

bobi-mel commented

I thought in the future you could create another plugin where template_key displaying and disable_auti_loading are hidden. But we can separate this logic if it needs in any moment

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.