Problem/Motivation

Currently conditional_fields does not work with shs (Simple hierarchical select) module.

Proposed resolution

I am providing a patch that adds this feature.

CommentFileSizeAuthor
#2 3399173-compatibility-with-shs-1.patch1.01 KBramil g

Comments

ramil g created an issue. See original summary.

ramil g’s picture

ramil g commented
Status: Active » Needs review
StatusFileSize
new 3399173-compatibility-with-shs-1.patch1.01 KB

This patch makes conditional_fields work with the shs module.

ramil g’s picture

ramil g commented
Related issues: +#2038019: Using shs with conditional_fields module does not work
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Reviewed & tested by the community

Full disclosure, I work with ramil g, and I think this is an elegant solution to providing compatibility to a widget that is effectively a Select widget, just more advanced.

Marking as RTBC because we are using it in production.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented

Thanks for the report, the work, and the review on it! And Thanks @joelpittet for the production testing and review. Will be committed in the next hours.

  • dqd committed 4a6aeeb7 on 4.x authored by ramil g 
    Issue #3399173 by ramil g, joelpittet, dqd: Compatibility with shs...
dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Reviewed & tested by the community » Fixed

Thanks at all! Awesome work! +1

And sorry for the delay.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.