Problem/Motivation

Currently there are some code errors reported in PHPStan CI job:

 ------ ---------------------------------------------------------------- 
  Line   tests/src/Kernel/Entity/EntityViewModeDeleteFormHelperTest.php  
 ------ ---------------------------------------------------------------- 
  136    No error to ignore is reported on line 136.                     
 ------ ---------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------ 
  Line   tests/src/Kernel/Plugin/Field/FieldType/ViewModeSwitchItemListTest.php  
 ------ ------------------------------------------------------------------------ 
  159    No error to ignore is reported on line 159.                             
 ------ ------------------------------------------------------------------------ 
 ------ -------------------------------------------- 
  Line   view_mode_switch.install                    
 ------ -------------------------------------------- 
  66     No error to ignore is reported on line 66.  
 ------ -------------------------------------------- 
 [ERROR] Found 3 errors       

Steps to reproduce

  • Check output of recent PHPStan job(s) in CI

Proposed resolution

  • Fix code quality issues

Remaining tasks

  • Create patch/MR to fix the code quality issues

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

hctom created an issue. See original summary.

hctom’s picture

Status: Active » Needs review

Fixes are contained in the associated issue fork and MR.

hctom’s picture

Status: Needs review » Fixed

  • hctom committed 76bb883d on 2.x
    Issue #3398655 by hctom: Fix code quality issues reported by PHPStan
    
hctom’s picture

Status: Fixed » Closed (fixed)