Closed (fixed)
Project:
JSX Theme Engine
Version:
1.0.x-dev
Component:
Umami JSX Demonstration Theme
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Nov 2023 at 15:56 UTC
Updated:
15 Nov 2023 at 17:39 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
hooroomooComment #3
hooroomooComment #7
effulgentsia commentedYep, this prop was incorrectly declared and JSX.Element is more appropriate, so merged.
I also opened #3398446: Add type coercion logic to jsx.engine so that themes can declare prop types based on their needs, not on knowledge of Drupal internals to add more resilience to the system (requesting a different type should not cause a fatal error) and #3398448: Document how a theme should choose which types for a component's props to provide information about how to select the best type.