To support persistent login module added to autologout.module after Persistent D10 Upgrade

CommentFileSizeAuthor
autologout-persistent-support-fix.patch1.58 KBsubramani.msc2011

Issue fork autologout-3398250

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

subramani.msc2011 created an issue. See original summary.

admirlju made their first commit to this issue’s fork.

admirlju opened merge request !51

admirlju’s picture

admirlju commented
Status: Active » Needs review

I've created an issue fork and tried to apply the patch to it, but it couldn't apply, so I manually added your code there. I also changed the code a bit, so Automated Logout will still work for anyone not using the Persistent Login module. It still needs review.

That said quick tests are working for me.

deaom made their first commit to this issue’s fork.

deaom’s picture

deaom commented
Version: 8.x-1.x-dev » 2.x-dev
Assigned: subramani.msc2011 » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: -8.1.4 release notes

There is an existing issue that addresses this in #3500246: Fix persistent login hashes checking. The existing issue does just change the if check, this one does a little more of a change. Up to maintainers to decide which way to go. I do think this one is older. Re-based branch, it needs to be changed from 8.x to 2.x and setting status to RTBC.

the_g_bomb’s picture

the_g_bomb commented
Status: Reviewed & tested by the community » Closed (duplicate)

Closing this as a duplicate. Going with the approach in #3500246: Fix persistent login hashes checking.

The validation will also rotate the token and may burn through tokens unnecessarily.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.