Under some circumstances $this->value['type'] is undefined, resulting in the warning
Warning: Undefined array key "type" in Drupal\search_api\Plugin\views\filter\SearchApiDate->opBetween() (line 103 of modules/contrib/search_api/src/Plugin/views/filter/SearchApiDate.php).
It should have the same sanity check as $this->value['max'] just above it.
Unknown.
Add a sanity check that matches the one just above it.
Make a fork.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3398192-undefined-array-key.patch | 1.99 KB | admirlju |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
benstallings commentedComment #4
admirlju commentedQuickly generate a patch file, from your repository. Since automated testing on the GitLab pipeline at the moment doesn't work correctly for Search API.
Comment #5
admirlju commentedThe automated tests are passing and the sanity check works correctly. I think this can be merged. RTBC.
Comment #7
drunken monkeyThanks for reporting this problem!
We actually already guard against this a few lines further down, in
opSimple(), but apparently forgot it there. Or maybe it occurs even rarer inopBetween(). Anyways, I think we should just use the same fix we used there:($this->value['type'] ?? '') == 'offset'.(I also don’t quite understand why we don’t just set
$base_timestampregardless, but probably out of scope here.)Anyways, merged a simplified version of the MR. Thanks again, everyone!