Closed (fixed)
Project:
Bibliography Module
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Nov 2008 at 11:19 UTC
Updated:
12 Dec 2008 at 18:18 UTC
Hi,
the "Autocomplete" setting for biblio_contributors is not considered in the contributors sub form. Since autocompletion fails with Opera and even with some Firefox at our site, I wrote the following patch to pass the setting down to the contributors form.
cu,
Frank
| Comment | File | Size | Author |
|---|---|---|---|
| biblio_contributors_autocompletion.patch | 1.51 KB | Frank Steiner |
Comments
Comment #1
rjerome commentedI'm a bit surprised, is this a known problem with Opera and the FormsAPI? I've never seen it now work with various flavours of Firefox and IE.
Comment #2
Frank Steiner commentedWell, I'm not sure. I never worked with my Opera but did well with my Firefox. But today we were sitting at the desktop of a colleague, and with his Firefox autocompletion also failed, so we decided to disable it (which didn't work then ;-)). Opera is able to handle this kind of autocompletion with other sites, so it must be sth. specific to the javascript code in drupal...
Comment #3
rjerome commentedWhen you say failed... what do you mean? What exactly happens (or doesn't as the case may be).
And the code in this patch fixes the problem? I wonder if the dupal autocomplete is competing with the built in browser form autocomplete?
Ron.
Comment #4
Frank Steiner commentedIt pops up a windows saying "An error occured" and shows some html code (with stuff like "{ "Frank" ...").
The patch is completely unrelated to this bug! It just allows to disable the autocompletion for authors. At the moment, the autocompletion settings defined at /admin/settings/biblio/defaults are considered for all fields but the author fields, those always use autocompletion, no matter if it is enabled or disabled for biblio_contributors at /admin/settings/biblio/defaults
The patch just makes the contributor widget consider the setting, i.e., remove the autocompletion for author input fields if it was switched of at /admin/settings/biblio/defaults.
I'm going to debug the error with Opera and Firefox further because this really bugs me :-) I'll let you know!
Comment #5
rjerome commentedAhhh, now I understand... I'm a bit slow sometimes.
Comment #6
rjerome commentedPatch tested and committed to CVS...
Ron.
Comment #7
Frank Steiner commentedJust to let you know: The problem with autocompletion was because the devel module was active at our site (and has been so for the last months). The output of the time the page took to load destroyed autocompletion. After we disabled that output, autocompletion now works fine with Opera and Firefox :-)
Thanks for committing the patch anyway :-)
Comment #8
rjerome commentedOk, now we know...
...clearly the patch was required regardless, I just misinterpreted it's function.
Ron.