Problem/Motivation

If configuration is imported in order to change the id of an existing matcher then the new id will be discarded.

The method MatcherBase::setConfiguration() completely discards the id parameter so that it can not be set through e.g. drush cim --partial or drush cedit.

Steps to reproduce

Use drush cedit or drush cim --partial to adjust a linkit profile by editing the matcher id.

Proposed resolution

Make sure that the id parameter is set according to the updated configuration.

CommentFileSizeAuthor
#2 3397743-2.patch1.15 KBmeanderix

Comments

meanderix created an issue. See original summary.

meanderix’s picture

meanderix commented
StatusFileSize
new 3397743-2.patch1.15 KB

Here is my proposed patch, which is much more in line with how other modules handle this. See e.g. Drupal\ckeditor5\Plugin\CKEditor5PluginConfigurableTrait and Drupal\workflows\Plugin\WorkflowTypeBase.

keshavv’s picture

keshavv commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3397743-2.patch, failed testing. View results

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

I see you are deleting where UUID and Weight variables are being set, is this on purpose?

- $this->uuid = $configuration['uuid'];
- $this->weight = $configuration['weight'];

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Version: 6.1.x-dev » 7.x-dev