[1.0.x] Marvelous

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,>DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the branch to review and the project name.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications, even to leave a comment similar to the following one. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• It is also preferable to wait before using a CLI tool to report what needs to be changed, especially because the comment left from Code Review Administrators suggests to use PHP_CodeSniffer. Before that, manual reviews should be done.
• Reviewers should not copy-paste the output of a CLI tool. They should use a CLI tool only once per application. When they do that, they should later verify the code has been correctly changed; this means, for example, that adding a documentation comment that is not correct just to avoid to get a warning/error is not a correct change that should be reported in a further comment.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

Remember to change status, when the project is ready to be reviewed, as the used status is telling reviewers not to review the project, yet.

FILE: marvelous.info.yml

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

Rest looks fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

Hello,

I found issue on installation of Marvelous theme 1.0.0 beta2 in Drupal 10.

Drupal\Core\Config\UnsupportedDataTypeConfigException: Invalid data type in config system.menu.community, found in file themes/contrib/marvelous/config/install/system.menu.community.yml: Duplicate key "dependencies" detected at line 9. in Drupal\Core\Config\FileStorage->read() (line 118 of /var/www/html/drupal10/web/core/lib/Drupal/Core/Config/FileStorage.php).

There is some duplicate entry of dependencies key in some config file.

Thanks

This is not an issue created in a project queue.
Comments in this queue are required to review the project files and report what needs to be changed. We do not debug projects.

Ok, We will create issue on project queue.

@Rushikesh Raval: Remove unwanted empty function from the marvelous.theme file

/**
 * Marvelous settings form submit.
 */
function marvelous_settings_form_submit(&$form, FormStateInterface $form_state) {
  // $account = \Drupal::currentUser();
  // $values = $form_state->getValues();
}

• What follows is a quick review of the project; it doesn't mean to be complete
• For each point, the review usually shows some lines that should be fixed (except in the case the point is about the full content of a file); it doesn't show all the lines that need to be changed for the same reason
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance

theme-settings.php

/**
 * @file
 * Implements().
 */

use Drupal\Core\Form\FormStateInterface;

/**
 * @file
 * Marvelous theme file.
 */

The @file tag is used once per file.
For that file, the description is Functions to support [theme name] theme settings. where [theme name] is the name given in the theme's info.yml file.

/**
 * Dark awesome form alter.
 */
function marvelous_form_system_theme_settings_alter(&$form, FormStateInterface $form_state, $form_id = NULL) {

That seems a documentation comment copied from another project, not a documentation comment for a hook implementation. It is not necessary to define the third parameter. See olivero_form_system_theme_settings_alter() as example.

if ($form['#attributes']['class'][0] == 'system-theme-settings') {

There should be any need to check the value of $form['#attributes']['class'][0], since marvelous_form_system_theme_settings_alter() is only invoked to alter a single form, which is the form for the theme settings implemented by the System module.

    $form['show_header_color']['header_colors'] = [
      '#type' => 'details',
      '#title' => t('Header Background Color'),
      '#collapsible' => TRUE,
      '#collapsed' => FALSE,
    ];

A details form element does not use #collapsible nor #collapsed; it uses #open.

      $form['banner']['slideshow']['hero_color'] = [
        '#type' => 'textfield',
        '#title' => t('Background-color'),
        '#default_value' => theme_get_setting('hero_color'),
        '#description' => t("Enter Hero color, code manually"),
      ];

For colors, it is probably better a color form element.

      $form['banner']['slideshow'] = [
        '#type' => 'details',
        '#type' => 'hidden',
        '#title' => t('Slider'),
        '#collapsible' => TRUE,
        '#collapsed' => FALSE,
      ];

Either that is a details element, or an hidden element.

    $form['show_footer_first_details']['footer_details']['footer_text'] = [
      '#type' => 'textfield',
      '#title' => t('Company Name'),
      '#default_value' => theme_get_setting('footer_text'),
      '#description' => t("Enter your Company Name"),
    ];
    $form['show_footer_first_details']['footer_details']['footer_email'] = [
      '#type' => 'email',
      '#title' => t('Company email'),
      '#default_value' => theme_get_setting('footer_email'),
      '#description' => t("Enter your Company email"),
    ];

The second parameter for theme_get_setting() is missing, which means those function calls are returning the value for the currently active theme, not this theme. The second parameter should be provided, as it has done for the other calls to the same function.

    $form['show_footer_first_details']['footer_details']['footer_phone'] = [
      '#type' => 'textfield',
      '#title' => t('Company Phone'),
      '#default_value' => theme_get_setting('footer_phone'),
      '#description' => t("Enter your Company Phone"),
    ];

For a telephone number, it is better a telephone form element.

$theme_file = \Drupal::service('extension.list.theme')->getPath($theme) . '/marvelous.theme';

The correct way to get a theme path is calling \Drupal\Core\Extension\ExtensionPathResolver::getPath() (Drupal 9.3+) or drupal_get_path() (previous Drupal versions). Since the theme declares to be compatible with Drupal 8 (starting with Drupal 8.8), Drupal 9 (any version), and Drupal 10 (any version), the same code cannot be used for all those versions.

templates/page/page.html.twig

The documentation comment present in any template file is missing.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the Slack #contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.