Problem/Motivation

I found an issue with the admin tool bar search results where when clicking the autocomplete result, the links are opening twice.

Steps to reproduce

Adding a simplyTest.me video for reference.

Proposed resolution

TO fix the issue i did the below:

Before : 

.append('<div ><a href="' + item.value + '" onclick="window.open(this.href); return false;" >' + item.labelRaw + ' <span class="admin-toolbar-search-url">' + item.value + '</span></a></div>')

After :
.append('<div ><a href="' + item.value + '" onclick="window.open(this.href, _self); return false;" >' + item.labelRaw + ' <span class="admin-toolbar-search-url">' + item.value + '</span></a></div>')

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 admin_search_toolbar_links_insame_window-3397157.patch894 bytesvakulrai
Screen Recording 2023-10-27 at 3.15.03 PM.mov5.52 MBvakulrai

Comments

vakulrai created an issue. See original summary.

vakulrai’s picture

vakulrai commented
Issue summary: View changes
vakulrai’s picture

vakulrai commented
StatusFileSize
new admin_search_toolbar_links_insame_window-3397157.patch894 bytes

Adding a patch to fix the issue , this is definitely can be made configurable but to start off i am adding it so that others facing the same can use it.

Thanks

vakulrai’s picture

vakulrai commented
Issue summary: View changes
dydave’s picture

dydave commented
Status: Active » Closed (outdated)

Thank you very much Vakul (@vakulrai) for reporting this issue and contributing a patch, it's greatly appreciated! 🙏

The Admin Toolbar Search module's Javascript has been completely refactored in the latest release and this issue should have been Fixed as part of the latest changes.

Could you please try testing the latest release 3.6.3 and let us know if the problem still persists?

This issue was initially reported for the 3.4.2 release, so it is a bit outdated now....

Marking as Closed (outdated), for now.

Thanks again very much for your help and interest in the Admin Toolbar module! 😊

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.