Closed (fixed)
Project:
Salesforce Suite
Version:
5.0.x-dev
Component:
salesforce.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Oct 2023 at 09:45 UTC
Updated:
28 Nov 2023 at 20:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mohd sahzad commentedComment #3
kevinn commentedHere is patch to solve the issue.
Comment #4
mohd sahzad commentedI have updated this issue in attached patch1
Comment #5
mohd sahzad commentedComment #7
aaronbaumanCommitted, thanks for the patch.
I'm went with #3, which has a better comment.
{@inheritdoc}is not appropriate here: the parent does not define this property, there is nothing to inherit.Also, a point of issue queue etiquette @Mohd Sahzad:
Give someone more than a minute to post a patch when they open a new issue before you assign it to yourself. If someone else has already posted a patch, there's no good reason to post a 2nd patch which does the same thing. If you do post a followup patch, make sure you're specifying the reasons for doing so in your comment.
Comment #8
damienmckennaIs there anything still needed on this or can it be closed?
Comment #9
aaronbaumanshould have been marked "fixed"
while i have your attention though, i'll cross-post a big MR in #3398897: Creation of dynamic property $key which attempts to address the many many other dynamic properties.