Problem/Motivation

Creation of dynamic property Drupal\salesforce\Rest\RestClient::$time is deprecated

Proposed resolution

Declare property.

CommentFileSizeAuthor
#5 salesforce-3397134-patch1.patch365 bytesmohd sahzad
#3 3397134-2.patch410 byteskevinn

Comments

kevinn created an issue. See original summary.

mohd sahzad’s picture

Assigned: Unassigned » mohd sahzad
kevinn’s picture

Status: Active » Needs review
StatusFileSize
new410 bytes

Here is patch to solve the issue.

mohd sahzad’s picture

Assigned: mohd sahzad » Unassigned

I have updated this issue in attached patch1

mohd sahzad’s picture

StatusFileSize
new365 bytes

aaronbauman’s picture

Committed, thanks for the patch.
I'm went with #3, which has a better comment.

{@inheritdoc} is not appropriate here: the parent does not define this property, there is nothing to inherit.

Also, a point of issue queue etiquette @Mohd Sahzad:
Give someone more than a minute to post a patch when they open a new issue before you assign it to yourself. If someone else has already posted a patch, there's no good reason to post a 2nd patch which does the same thing. If you do post a followup patch, make sure you're specifying the reasons for doing so in your comment.

damienmckenna’s picture

Is there anything still needed on this or can it be closed?

aaronbauman’s picture

Version: 5.0.3 » 5.0.x-dev
Status: Needs review » Fixed
Related issues: +#3398897: Creation of dynamic property $key

should have been marked "fixed"

while i have your attention though, i'll cross-post a big MR in #3398897: Creation of dynamic property $key which attempts to address the many many other dynamic properties.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.