Autowire core modules that do not require explicit configuration

Autowiring is so cool. Wise I understood the sorcery fully.

But change didn't break anything so seems good.

Not sure if #3295751: Autowire core services that do not require explicit configuration should go first or whether we should just commit this all in one go.

If we have 2 issues about that, let's at least not have duplicate changes in both of them.

Came for the reroll, stayed for the community, but now removed the changes from core/core.services.yml and its testing, since that already/also lives in #3295751: Autowire core services that do not require explicit configuration.

And then stuff broke and testCoreAutowiring shows _way_ less services that could/should be auto-wired, because they are in core.services.yml.

Let's just postpone them on getting #3295751: Autowire core services that do not require explicit configuration so we don't have to reroll both on every change in core.services.yml

Was just about to do that, thanks @longwave

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Have one question on the MR, but otherwise this look close.

This needs a rebase due to module removals. For the record I haven't done my own review of it yet.

Comments addressed and lgtm.

Sorry about this. I started my own review of the former changes hours ago before @godotislate's last reply. But I was making so many notes about new opportunities for autowiring that I eventually decided to start editing it myself. The biggest change is obviously the use of the #[Autowire] attribute for services. I noticed that these changes were originally written before its introduction. It allowed me to autowire a bunch more of them.

I split up the commits by module, aside from the few fixes that came later. So if it's easier for someone to review the changes module-by-module (as opposed to in one big list in the MR changes page), then you have that option.

The "that do not require explict configuration" in the title was meant to imply that we would not add any attributes here

Obviously I didn't understand that. Oh well. It's easily reverted. I saved the work that I did in a patch so it can be applied to the next issue.

I reverted all of my commits back to the last thing from @longwave and was RTBC. So I'm resetting that status.

Needs a rebase.

Committed/pushed to main, thanks!