Problem/Motivation

The update hook simplenews_update_840004 replaces the token [simplenews-subscriber:combined-url] in setting subscription.confirm_combined_body with [simplenews-subscriber:confirm-url. Because of the missing closing bracket, the token does not work anymore.

Steps to reproduce

  • Setup Drupal 9 project
  • Install simplenews:^3
  • Configure simplenews
  • Set setting subscription.confirm_combined_body with token [simplenews-subscriber:combined-url]
  • Update to simplenews:^4
  • Run update hooks
  • Token replacement failed: [simplenews-subscriber:confirm-url

Proposed resolution

I will provide a MR with a fix

Issue fork simplenews-3396925

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

JoCowood created an issue. See original summary.

JoCowood opened merge request !42

adamps’s picture

adamps commented
Status: Active » Reviewed & tested by the community

Thanks. The branch tests are broken - I'll commit this as soon as someone can get them working again.

adamps’s picture

adamps commented
Status: Reviewed & tested by the community » Needs review
adamps’s picture

adamps commented

I can't understand why the Gitlab tests are failing as they work on drupal CI. So I've re-enabled the drupal tests. Now we just need to get them to run on this MR, and I can't seem to do it. Maybe someone else knows how??

  • AdamPS committed 4a512d0a on 4.x authored by JoCowood 
    Issue #3396925: Update hook 840004 token replacement missing bracket
adamps’s picture

adamps commented
Status: Needs review » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.