Closed (fixed)
Project:
Navigation
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Oct 2023 at 09:01 UTC
Updated:
30 Nov 2023 at 13:39 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #3
saschaeggiUpdate
Comment #5
saschaeggiUpdate credit
Comment #6
saschaeggiComment #7
saschaeggiComment #9
kostyashupenkoNew before/after. Added some padding for the texts to prevent interflow
Before:
After:
Comment #10
ckrinaThanks for the proposal @saschaeggi! But from my understanding not displaying the full label in menu items is not a good practice. I would expect it to break into 2 lines to not leave out important information a site admin/editor might need instead of forcing ~20 characters on the label. I would assume, also, that somebody using a bigger font-size would see even less characters.
I can be wrong so I'll do some research, but feel free to point to any resource that proves it's a good practice. Meanwhile I'll leave this as NR so some other people takes a look to it.
Comment #11
gddI agree this is a bad idea. Truncating text can lead to unfortunate wordings that are embarassing and/or damaging for customers (think about the ways in which analyze or associate might be truncated as an example.) This problem would only be made worse when we consider all the non-English options.
The best choice would be to break to multiple lines and show the complete text of the menu item.
Comment #12
saschaeggiI totally agree that showing the full item name would be better 👍 Let's proceed with this 👌
Comment #13
ckrinaThank all! Then moving this to Needs Work to update adjust to the current styles in 2 lines for the first level item in a similar way to @kostyashupenko's work on the sub-menu items.
Comment #14
kostyashupenkoComment #15
ckrinaThanks @kostyashupenko! I've just reviewed it and I think the sub-levels are missing the
flex-shrink: 0;part you've added on the top one:Comment #16
kostyashupenkoComment #17
ckrinaThanks everybody!
Comment #18
finnsky commentedAfter refactor this feature is gone.
We need some work here
Comment #20
kostyashupenkoComment #21
finnsky commentedThank you!
Comment #22
ckrinaI've just merged it, thanks! For the next time if you open a new issue (because it's new work that came up) I'll be able to give you the proper credits for it :)