Problem/Motivation

Upgrading to PHP 8.1 ran into these.

    Deprecated function: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in template_preprocess_date_views_pager() (line 88 of /var/www/html/public/sites/all/modules/contrib/date/date_views/theme/theme.inc).
    Deprecated function: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in template_preprocess_date_views_pager() (line 102 of /var/www/html/public/sites/all/modules/contrib/date/date_views/theme/theme.inc).

Steps to reproduce

Proposed resolution

Cast $subject to a string.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork date-3396444

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review

joelpittet opened merge request !25

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

8.2 has maybe unrelated issues to resolve.

Focus on 8.1:
Triggered additional test for PHP 8.1

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Needs work

The proposed fix actually breaks PHP 8.2 which , HEAD tests were previously passing.

chetan 11 made their first commit to this issue’s fork.

chetan 11 opened merge request !26

chetan 11’s picture

chetan 11 commented
Status: Needs work » Needs review

Hi,
I have fixed the above issue, please check the raised MR.
Thanks.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Needs work

see the test results passing here on fresh runs:

https://www.drupal.org/node/70963/qa

This patch introduces two failures