Problem/Motivation

As a follow-up to #3395493: Join top and middle regions let's rename the bottom region to sticky.

Steps to reproduce

Proposed resolution

Rename bottom region to sticky.

Remaining tasks

-

User interface changes

-

API changes

-

Data model changes

-

Issue fork navigation-3395813

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

saschaeggi created an issue. See original summary.

saschaeggi opened merge request !107

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Active » Needs review
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

As mentioned in Slack we discussed exactly that on the CSS refactor, but on mobile this region is not sticky anymore. That’s why we kept bottom. Happy to change it to something more useful than bottom that still applies regardless of it being sticky :)

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Needs work

As mentioned in Slack we discussed exactly that on the CSS refactor, but on mobile this region is not sticky anymore. That’s why we kept bottom. Happy to change it to something more useful than bottom that still applies regardless of it being sticky :)

finnsky’s picture

finnsky commented

we have:

1. header.
2. content.
3. bottom. (for me it should be footer)

saschaeggi’s picture

saschaeggi
he/him
commented

Footer? Meta?

finnsky’s picture

finnsky commented

Yes. Semantically it will be part of NAV

But in BEM we will add

admin-toolbar__header
admin-toolbar__content
admin-toolbar__footer

Simple logic imo

saschaeggi’s picture

saschaeggi
he/him
commented

@finnsky that sounds about right 👍

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented

Good idea!

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Issue tags: +Needs reroll

Rebase required

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Fixed

Rebased and changed the name to footer. Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.