Problem/Motivation

with Drupal 10.2.x, I'm getting the following error -

PHP Fatal error: Type of Drupal\geocoder\Form\SettingsForm::$typedConfigManager must be ?Drupal\Core\Config\TypedConfigManagerInterface (as in class Drupal\Core\Form\ConfigFormBase) in /var/www/web/modules/contrib/geocoder/src/Form/SettingsForm.php on line 14

Steps to reproduce

with the Drupal core updated to 10.2.x - run "drush cr" and you will see the error

Proposed resolution

in Drupal\geocoder\Form\SettingsForm line 14 needs to be changed like so -

protected ?TypedConfigManagerInterface $typedConfigManager;

Remaining tasks

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#7 geocoder-3395751-7-patch_for_4.23.patch536 bytesjoshahubbers

Comments

oivanov created an issue. See original summary.

  • itamair committed a4bea42d on 8.x-4.x 
    Issue #3395751: with Drupal 10.2.xx - PHP Fatal error:  Type of Drupal\...
itamair’s picture

itamair commented
Status: Active » Fixed

thanks @oivanov, your suggestion committed into 8.x-4.x-dev, will be part of the next Geocoder 8.x-4.x release

oivanov’s picture

oivanov commented

Happy to help!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vishalkhode’s picture

vishalkhode commented

@itamair/@oivanov: I think we have to revert commit: a4bea42d, since it's currently causing a failure with Drupal Core 10.2.0-rc1. This issue arose due to a regression in Drupal Core 10.2.x, and it has been resolved as part of #3394197: [regression] The new property \Drupal\Core\Form\ConfigFormBase::$typedConfigManager conflicts with some contrib modules.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new geocoder-3395751-7-patch_for_4.23.patch536 bytes

Patch with this change for 4.23. This fix is not in that release and my drush updb got stuck on this when upgrading to 10.2.
So no new development, just the patch file to use in composer.json.

joshahubbers’s picture

joshahubbers commented

Excuse me... I just realize that I did not update to the latest version of 10.2. While updating to the latest version, this patch had to be removed again. Sorry for the confusion.