Closed (fixed)
Project:
Ckeditor drupalbreaks
Version:
3.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
20 Oct 2023 at 16:01 UTC
Updated:
18 Aug 2025 at 16:49 UTC
Jump to comment: Most recent
Show commands
changes
Comments
Comment #2
mysdiir commentedHaving a problem with pushing my code.
The error message says:
when trying to push my branch into 2.0.x.
I created a new custom access token and use those information to log in, but it keeps denying the access.
Any ideas?
Comment #3
dsnopekIt looks like you're trying to push to the main project repository, rather than the issue fork. Try changing your remote to
git@git.drupal.org:issue/ckeditor_drupalbreaks-3395704.git- the git commands would be something like:But if all else fails, you can always attach a patch the old-fashioned way :-)
Comment #4
mysdiir commentedthx @dsnopek for your help.
I pushed the changes. If anything is unclear or need to be done just tell me :)
Comment #6
dsnopek@Mysdiir Thanks!
So that it'd be easier to put review comments on the diff I made an MR and added quite a few notes:
https://git.drupalcode.org/project/ckeditor_drupalbreaks/-/merge_requests/3
Please let me know if you're interested in making those changes. Otherwise, I'd be happy to take this over and finish it up :-)
Comment #7
mysdiir commentedSure if you want to change it feel free to do it :)
When it's all finished, I'll look up the changes and see what I can learn from it :)
Comment #8
mysdiir commentedmade suggessted changes with removing
package.json,package-lock.json,yarn.lockandwebpack.config(for generating a minified version).So you should have access to those files
Comment #9
dsnopekThanks!
I've updated the code on the GitLab issue fork such that it's now working in my testing :-)
Comment #10
mysdiir commentedIf needed I can test it on local setup too, so we have a double confirmation that it works
Comment #11
drupatz commented@dsnopek Hi, using the element
<drupalbreaks>causes the cke adding and<p>tags, resulting in<p><drupalbreaks> </drupalbreaks></p>-- in my point of view this isn't a sober solution. Therefore i did that via the hr element:<hr class="cke-drupal-break">, where this doesn't happen. Of course, this also isn't a sober solution.When using
<drupalbreaks>, maybe there is a possibility in drupalbreaksEditing.js to tell cke to not add anything?Comment #12
mysdiir commented@drupatz The problem with not adding any HTML tag values in
drupalbreaksEditing.jsis, that this file provides the logic for DOM manipulation between CKEditor and Drupal, said in MVC pattern: the CKEditor upcast and downcast pipeline are representative for view layer and model layer. This is where adding the<drupalbreaks>tag insertion happens and gets converted to Drupal.The basic logic behind my module modification is that CKEditor manipulates the DOM with insertion of the HTML tag.
This tag is fetched by
DrupalbreaksFilter.phpand swapps<drupalbreaks>to<!--break-->which Drupal magic interprets as break between content and teaser.But I agree with you that the additional
<p>is unnessesary.I'd appreciate a feedback if the merged changes by @dsnopek are working as intended.
Comment #13
dsnopek@drupatz:
As @Mysdiir mentions, if you enable the Drupalbreaks filter on your text format, it will convert the
<drupalbreaks> </drupalbreaks>to<!--break-->.I've just pushed a commit that will get rid of the extra
<p>too.I'm thinking of merging this into a new branch (perhaps 2.1.x or 3.0.x -- I'm not sure yet) so that it's easier to pull into a site and test. We're not fully committed to this approach until we make a proper release. :-)
Comment #15
dsnopekComment #16
andkar commentedThanks for this update! It is working fine!
Comment #17
tobiasbMissing is a upgrade path (Need to manually enable button again) and existing
<!--break-->are gone, when open content with CKEditor5.Comment #18
codesmithThis worked pretty well for me on Drupal 10/CK editor 5. I had to re-add the button to the editor and enable the "Process the output of the Drupalbreaks CKEditor plugin" filter. Existing content that had a teaser break worked fine on the front end. When editing however, the double red teaser line isn't shown.
is in the code but is not highlighted - only the new " " is highlighted.
So while this does work, I'd agree with #17 that there needs to be an upgrade to convert "
" in content to " "
Comment #19
ladybug_3777 commentedI had the same experience as #18. Had to re-add the button and enable the filter (I missed the filter step my first time through).
I also noticed that when editing existing content the red highlight was not displayed, but re-saving the content worked fine and did not alter functionality as long as the underlying break tag stayed intact.
Adding new breaks with the new button worked fine.
Comment #20
anybody@dsnopek any plans to finish this and make the module D11 compatible? Or is the module unmaintained?
Thanks! :)
Comment #21
m4oliveiThis has been working for us on Drupal 10.x (we've been running the 3.0.x branch commit that was finished here in #14).
I want to suggest that we close this out, open a new issue for the update path (if anyone is interested). And then continue work in #3438199: Automated Drupal 11 compatibility fixes for ckeditor_drupalbreaks for the Drupal 11 compatibility.
Comment #22
m4oliveiFiled #3539610: Needs upgrade path from CKEditor4 to CKEditor5 plugin for the upgrade path.