Problem/Motivation

Currently the l10n_server has an xmlrpc endpoint for

Proposed resolution

Introduce a new endpoint based on REST/JSONAPI

Remaining tasks

  • Find a suitable way to authenticate the user who is pushing translations to localize.drupal.org (See https://www.drupal.org/project/l10n_client/issues/3395488).
  • Figuring out why we need the L10nRemoteSubscriber event subscriber for, and either remove debug traces or remove it completely.
  • Properly check access in L10nServerContributorResource::access(): user should be a member of the translation team. That being said, we most certainly should implement access checks properly in #3437137: Translation suggestion creation and moderation don't provide group permission instead.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Harlor created an issue. See original summary.

harlor’s picture

harlor’s picture

Component: Documentation » Code
harlor’s picture

Status: Needs work » Needs review
harlor’s picture

Issue summary: View changes
fmb’s picture

Status: Needs review » Needs work

Thanks for your contribution @Harlor! While I've never dealt with REST endpoints myself, I added some minor comments, some of them less minor, such as permission issues.

Once we are done with this, ideally you should enable the module on the platform on gitlab.com and open an MR there for core.extension.yml.

Just so I can get a general idea for the Localize project, do you have an idea of how much work is left, and what time you might be able to dedicate in a month? In your opinion, how many developers should be working on this?

(P. S.: I still have your charger, I'll need your email address to finalize shipping.)

azhardotcoder made their first commit to this issue’s fork.

azhardotcoder changed the visibility of the branch revert-917a89be to hidden.

azhardotcoder changed the visibility of the branch l10n_server-3395508-3395508-contributor-endpoints to hidden.

azhardotcoder changed the visibility of the branch 3.0.x to hidden.

azhardotcoder’s picture

Status: Needs work » Needs review
  • Remove Unused JSON:API Resource Configurations and Adjust Dependencies
    • Deleted obsolete JSON:API resource configuration files:
      • jsonapi_extras.jsonapi_resource_config.l10n_server_string.yml
      • jsonapi_extras.jsonapi_resource_config.l10n_server_translation.yml
      • jsonapi_extras.settings.yml
    • Removed unnecessary dependency on jsonapi_extras module.
fmb’s picture

  • Harlor committed ba6471c2 on 3.0.x
    Issue #3395508: Add access casllback to contribution endpoint
    

  • Harlor committed 05a104a1 on 3.0.x
    Issue #3395508: Remove oauth stuff for now
    

  • Harlor committed 369acad2 on 3.0.x
    Issue #3395508: Add a validation normalizer for the contribution...

  • Harlor committed 18e15405 on 3.0.x
    Issue #3395508: Init l10n_remote rest endpoint
    
fmb’s picture

Status: Needs review » Needs work

Thanks! Next steps:

fmb’s picture

Issue summary: View changes

guiu.rocafort.ferrer made their first commit to this issue’s fork.

donquixote’s picture