This issue is a companion to #2851580: Re-order + remove broken with the Entity Reference (and File) widget.

If the patch from that issue is applied, the remove button doesn't function properly in the EntityReferenceBrowserTableWidget plugin.

CommentFileSizeAuthor
#9 3395042-6.patch5.43 KBbeloglazov91
#5 3395042-5.patch6.46 KBjeroent
#4 3395042-4.patch5.46 KBjeroent

Issue fork entity_browser_table-3395042

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

weekbeforenext created an issue. See original summary.

weekbeforenext opened merge request !4

JeroenT made their first commit to this issue’s fork.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Active » Needs review
StatusFileSize
new 3395042-4.patch5.46 KB

The MR fixed the sorting problem for me, but removing items was still broken.
I made some changes to the MR that fixed removing the items for me.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new 3395042-5.patch6.46 KB

Added a patch for composer patches.

edmund.dunn’s picture

edmund.dunn commented

This one worked or us!

iamdroid’s picture

iamdroid commented

Hi folks, thanks for your work on this.

Patch from #5 works for me as well.

smustgrave’s picture

smustgrave commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs review » Needs work

May be nice to get test coverage too.

beloglazov91’s picture

beloglazov91
he/his
commented
Issue summary: View changes
StatusFileSize
new 3395042-6.patch5.43 KB
beloglazov91’s picture

beloglazov91
he/his
commented
Status: Needs work » Needs review
beloglazov91’s picture

beloglazov91
he/his
commented
Issue summary: View changes
beloglazov91’s picture

beloglazov91
he/his
commented

3395042-6.patch is compatible with 2.x branch.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Fixes should be in MRs please

smustgrave closed merge request !4

smustgrave opened merge request !11

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Disclosure used claude code for the js part but took what was there in the MR for the widget and used entity_browser for test coverage. Manual testing appears to be working.

smustgrave closed merge request !11

smustgrave opened merge request !13

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.