Create more organized views when viewing Quiz Results.

The patch is failing against the current 3.x dev branch -- probably because of all of the patches that I have added. Can you regenerate it for me?

Matt

Oops... let me be more specific -- only quiz_module_admin_view_v_1.patch is failing. The other applied.

This patch has been applied and has been (sorta) tested. I'm now checking it in.

A recent issue (#340573: A couple of Questions and a few thoughts) requested a way to do mass deletions of old quizzes. What do you think about changing the delete link to a checkbox and adding an actions menu at the top (like on the main 'content' list under Administer > Content managment > Content)?

That would allow mass deletions pretty conveniently.

iLLin: Thanks for another high-quality patch.

Oops... forgot to close this out.

Also, I re-arranged the menu structure to group all of the admin screens under a top-level quiz category. You will probably want to clear the cache when testing the newest version of the module.

Ooh... status... that will be an important one for Quiz 3.x, since we are now allowing question types that are not automatically scored.

We should probably come up with a term less generic than "status". Already, Drupal uses "status" for publishing status and Quiz uses status as the term to describe whether a question is on a quiz or not. (e.g. status: Always, Never, Random)

Today I am working on long answer scoring, so I will check to see what we can do on this particular issue.

Matt

In _quiz_get_quizzes() there is a select statement that looks like this:

$sql = "SELECT n.nid, n.title, u.name, n.created
          FROM {node} n
          INNER JOIN {quiz_node_properties} qnp
          INNER JOIN {users} u
          WHERE n.type = 'quiz'
            AND n.nid = qnp.nid
            AND u.uid = n.uid";

I'm having trouble figuring out what the INNER JOIN {quiz_node_properties} does there. Leaving it like that results in duplicate entries when I have multiple VIDs (versions) for a quiz, but then the next while loop just removes all of the duplicates.

Any reason I couldn't just get away with this query?

  $sql = "SELECT n.nid, n.title, u.name, n.created
          FROM {node} n
          INNER JOIN {users} u
          WHERE n.type = 'quiz'
            AND u.uid = n.uid";

Oh, I see that _quiz_get_results() used to have that same thing in there until I just recently removed it for the same reason. So I suppose if you had modeled the new function on that one....

Still, if you have any insight into why that extra inner join is a Good Thing (TM), let me know. There are some things about the construction of this module that I still don't quite understand.

The quiz_nodes_properties table stores one line per quiz version. Quizzes use the versioning system so that if a quiz is changed after a user takes the quiz, that person's score won't also be changed.

(Scenario: You add a new question to the quiz. Suddenly, anyone who already took the quiz automatically missed the new question.)

I tweaked some queries and it seems to be working fine on my local copy. Next time you take a look, let me know if I broke anything.

This is fixed in the 7.x-5.x branch. Everything was switched to entities, so all results are exposed to views.