Problem/Motivation

There are certain aspects of the Comment Notify module that are unclear and unintuitive. Updating this to use Drupal's user interface standards will improve the module's usability.

Steps to reproduce

Enable the module and visit the Comment notification settings page.

Proposed resolution

Update the module's interface to follow Drupal's user interface standards.

Remaining tasks

The following should be updated:

  1. Update "Bundles to enable for comment notification" to "Content to enable for comment notification"
  2. Update "Comments on bundle types enabled here will have the option of comment notification. Written as "Entity Type: Bundle: Comment field"." to "Comments on entity types enabled here will have the option of comment notificatiion."
  3. Remove the help text, "Choose which notification subscription styles are available for users"
  4. Change the Default state for the notification selection box from a select list to a checkbox
  5. Update "This flag presets the flag for the follow-up notification on the form that users will see when posting a comment" to "Choose the default subscription mode if both subscriptions modes are enabled.
  6. Update "If this is checked, new users will receive e-mail notifications for follow-ups on their entities by default until they individually disable the feature." to "Enable to email authors when new comments are published, unless they opt out for a specific content item."
  7. Update "Default mail subject for sending out node notifications to commenters" to "Default email subject for notifying commenters"
  8. Update "Default mail subject for sending out node notifications to authors" to "Default email subject for notifying authors"
  9. Update "node: Default mail text for sending out the notifications to entity authors" to "Default email message for notifying authors"
  10. Update "[comment:author] has commented on: "[node:title]" to "[comment:author] commented on "[node:title]"
  11. Update "You can view the comment at the following url [comment:url]" to "View the comment at [comment:url]"
  12. Update "You can stop receiving emails when someone replies to this post,
    by going to [comment-subscribed:unsubscribe-url]" to "Stop receiving emails when someone replies to this post,
    by visiting [comment-subscribed:unsubscribe-url]"
  13. Remove "You can set up auto-following feature for all future posts by creating your own user with a few clicks here [site:login-url]"
  14. Update "You will receive emails like this for all replies to your posts. You can
    disable this by logging in and changing the settings on your user account at
    [node:author:edit-url]." to "You currently receive emails like this for all replies to your posts. To
    disable this, log in and change your settings at
    [node:author:edit-url]."

User interface changes

See above.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 Screenshot from 2023-10-26 13-21-11.png230.34 KBdiwakar07
#5 Screenshot from 2023-10-26 13-21-19.png224.69 KBdiwakar07
#5 Screenshot from 2023-10-26 13-20-59.png250.42 KBdiwakar07

Issue fork comment_notify-3394711

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

cedewey created an issue. See original summary.

cedewey’s picture

cedewey
he/him
Primary language English
Location Denver, CO
commented
Issue summary: View changes

Diwakar07 made their first commit to this issue’s fork.

Diwakar07 opened merge request !11

diwakar07’s picture

diwakar07 commented
Assigned: cedewey » diwakar07
Status: Active » Needs review
StatusFileSize
new Screenshot from 2023-10-26 13-20-59.png250.42 KB
new Screenshot from 2023-10-26 13-21-19.png224.69 KB
new Screenshot from 2023-10-26 13-21-11.png230.34 KB

Hi,
I have updated the Comment Notify interface page accordingly.
Please review.

diwakar07’s picture

diwakar07 commented
Assigned: diwakar07 » Unassigned
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Thanks for this proposal, @cedewey and for making the fixes, @Diwakar07!

@cedewey are you able to review the proposed merge request?

indranil roy’s picture

indranil roy commented
Status: Needs review » Reviewed & tested by the community

Hey @Diwakar07,
I have tested your MR. LGTM.

alfthecat’s picture

alfthecat commented
Status: Reviewed & tested by the community » Needs work

Hi guys, thanks for the great work.

I ran into 3 issues after applying the patch (running Drupal 10.3.9):

1 - the new setting for "Default state for the notification selection box" is confusing because the help text: "Choose the default subscription mode if both subscriptions modes are enabled." implies that I should select 1 option yet there are checkboxes allowing me to select all or none of the states. I think that if the admin is prompted for a default state, there should be a required radio select widget that allows only one option.

2 - After I save the settings form I get a WSOD with error: 

The website encountered an unexpected error. Try again later.
InvalidArgumentException: The configuration property enable_default.watcher.1 doesn't exist. in Drupal\Core\Config\Schema\ArrayElement->get() (line 95 of core/lib/Drupal/Core/Config/Schema/ArrayElement.php).

3 - On the user account edit form, the text: "Check this box to receive email notifications for comments on your content (e.g. an article authored by you). You cannot disable notifications for individual threads." is confusing to end users because in my case they don't have the option to author articles. I think that in the help text it shouldn't be assumed site users are familiar with the article content type, and a more ambiguous text is perhaps better. I.e.: "Check this box to receive email notifications for comments on content you authored. You cannot disable notifications for individual threads."

Thanks and hope this helps.