Problem/Motivation

Under some circumstances (JS aggregation enabled) we noticed that leaflet_more_maps.js fails because it cannot find Drupal.Leaflet.

Steps to reproduce

Hard to reproduce because it depends on how JS is aggregated or in what order it is loaded.

Proposed resolution

The leaflet-more-maps library declares a dependency on leaflet/leaflet. This is incorrect, because Drupal.Leaflet is set in leaflet.drupal.js from the leaflet/leaflet-drupal library. Changing the dependency to leaflet/leaflet-drupal is needed.

The tiny attached patch fixes this.

CommentFileSizeAuthor
#2 3394335_leaflet_drupal_library_dep_1.patch379 bytesdennis_meuwissen

Comments

dennis_meuwissen created an issue. See original summary.

dennis_meuwissen’s picture

dennis_meuwissen commented
StatusFileSize
new 3394335_leaflet_drupal_library_dep_1.patch379 bytes
robloach’s picture

robloach
he/him
commented
Status: Active » Needs review

It's a 404... Is this correct? https://packagist.org/search/?query=leaflet%2Fleaflet-drupal

dennis_meuwissen’s picture

dennis_meuwissen commented

I should have been more clear; leaflet/leaflet-drupal is a Drupal library from the leaflet module, not a Composer library.

tjhellmann’s picture

tjhellmann
he/him
Primary language English
Location Indianapolis, IN
commented

Ran into this bug today and the patch fixed it. Thanks!

berramou’s picture

berramou commented

Thank you @dennis_meuwissen, for the report and the patch.

berramou’s picture

berramou commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.