Problem/Motivation

The module can't be installed on Drupal 10 because of Guzzle 6 dependency.

Steps to reproduce

Installing the module on a Drupal 10 site results in a composer error.

- drupal/do_username[1.0.0-beta1, ..., 1.x-dev] require php-http/guzzle6-adapter ^2.0 -> satisfiable by php-http/guzzle6-adapter[v2.0.0, v2.0.1, v2.0.2, 2.x-dev].

Proposed resolution

Require guzzle7-adapter instead.

Remaining tasks

Tag a new major release.

User interface changes

API changes

Data model changes

Comments

hussainweb created an issue. See original summary.

abhishek_gupta1’s picture

abhishek_gupta1 commented

@hussainweb, as per your point, I tried to install module in Drupal 10. I didn't get any such type error. its proper installed.

hussainweb’s picture

hussainweb
Primary language English
commented

@abhishek_virasat, did you try recently or are you saying that you were able to install this before I created this issue? I have already fixed this issue but for some reason, the commit doesn't appear here.

If you tried it recently, try installing the 1.x version of this module (composer require Drupal/do_username:^1.0). Alternatively, check if you have installed the 2.x version. This issue is fixed in 2.0.0-beta1.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
abhishek_gupta1’s picture

abhishek_gupta1 commented

@hussainweb, ok let me try.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 8.x-1.0-beta1 » 8.x-1.x-dev
Status: Needs review » Active

Since there are no patches/MRs to review, the status is still Active.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review

@apaderno, like I said in #3, the patch/commit is not visible here but there is still something that needs to be tested, and hence it is set to "Needs Review". From the documentation:

Note that if a patch is not required in order to complete the idea described in the issue, then it is the idea itself that needs review.

I am interpreting that as there is something here that needs to be reviewed and it is fine for the field to be set that way. I understand it might break your workflow and I don't know of any solution for that.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

A patch is not necessary if it's the project page that needs to be changed. In the case of code, a patch is used to change it.

The definition of the status itself does not say a patch is not necessary.

A policy, patch, or merge request has been created and needs peer review and testing. The automated testing infrastructure uses this status to trigger an automated review of the patch and reports the results. Patch reviewers also use this status to find patches that need to be reviewed and evaluated. With sufficient positive feedback, the patch may be promoted to the status "Reviewed & tested by the community" (see next definition). If a reviewer, either human or Bot, finds a problem with the patch, it will then be marked as "Needs work". Note that if a patch is not required in order to complete the idea described in the issue, then it is the idea itself that needs review.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs review » Needs work

I tried this again today and this still needs work. The module is installable on Drupal 10 if you use `Drupal/core` composer package. But not installable if you use `Drupal/core-recommended`.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Fixed

I released a new version of a dependency package that solves the problem for `core-recommended`. I then tested this on Simplytest and this module is installable on Drupal 10. No further change was needed in the module itself.

hussainweb’s picture

hussainweb
Primary language English
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.