Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 simplenews.view-subscriptions.3393892-2.patch510 bytesadamps

Issue fork simplenews-3393892

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new simplenews.view-subscriptions.3393892-2.patch510 bytes

Status: Needs review » Needs work

The last submitted patch, 2: simplenews.view-subscriptions.3393892-2.patch, failed testing. View results

adamps’s picture

adamps commented

Hmm, but that makes in unavailable for users who only have "administer simplenews subscriptions". Really we'd like to work with both, but can't see how.

davps made their first commit to this issue’s fork.

davps opened merge request !66

davps’s picture

davps commented
Status: Needs work » Needs review

@adamps, we can use own access plugin for views. MR !66 contains this solution.

adamps’s picture

adamps commented
Status: Needs review » Needs work

Neat, thanks. The tests are failing, it needs a schema.

davps’s picture

davps commented
Status: Needs work » Needs review

I added the scheme. Other tests are fixed in the #3476540: Fix tests for 4.x branch.

adamps’s picture

adamps commented

Thanks I committed the other one so please rebase so we can see the tests passing.

davps’s picture

davps commented

Codebase updated. Ready to review.

  • adamps committed 976f775f on 4.x authored by davps 
    Issue #3393892 by davps, adamps: Subscribers view should be accessible...
adamps’s picture

adamps commented
Status: Needs review » Fixed

Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.