Problem/Motivation

A drupal site running on elastic beansstalk will detect the current scheme as http and render redirect urls as http. There's no way to generate a https redirect url.

Proposed resolution

Add an option to use https regardless of existing scheme.

CommentFileSizeAuthor
#3 views-data-export-3392864-2-1.x-dev-force-https.patch4 KBerom
#2 3392864-1.x-dev-force-https.patch2.49 KBerom

Issue fork views_data_export-3392864

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

erom created an issue. See original summary.

erom’s picture

erom commented
StatusFileSize
new 3392864-1.x-dev-force-https.patch2.49 KB

I'm using this patch, the patch is for the dev branch.

erom’s picture

erom commented
StatusFileSize
new views-data-export-3392864-2-1.x-dev-force-https.patch4 KB

https applied to file url.

steven jones’s picture

steven jones commented

I wonder why we need to generate an absolute URL? Drupal used to do that, but these days would typically do it via a root-relative URL. I wonder if changing over to that would be simpler.

steven jones opened merge request !66

steven jones’s picture

steven jones commented
Status: Active » Needs review

Let's see what happens with this change.

steven jones’s picture

steven jones commented

Tests are still passing then, I'm inclined to merge this.

steven jones’s picture

steven jones commented
Title: Add option to force https on redirect url » Generate root-relative URLs for downloading files

Yeah, let's merge it.

  • steven jones committed 57546f02 on 8.x-1.x 
    Issue #3392864 by erom, steven jones: Generate root-relative URLs for...
steven jones’s picture

steven jones commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.