Problem/Motivation

#3386135: Update module's merge request process for current core HEAD fix the converter for 11.x on #3346707: Add Alpha level Experimental Package Manager module

We need it to work with #3253158: Add Alpha level Experimental Update Manager module so reviewers can see both in one 1 MR

Right now the conversion is being tested on #2977515: [ignore] Test Package manager core merge on the 2977515-pm-core-mr-9-2023 branch.
It is passing except for some functional test because of a new core bug #3392196: Exceptions in batch no longer are shown on the page when Javascript is disabled in 11.x

Steps to reproduce

Proposed resolution

Get the core merge request passing

It is combo of

  1. fixes for core 11.x compatibility, the module itself would fail if we could test again 11.x now
  2. Fixes to make Auto-Updates to work as core module

All functional tests will not pass yet because of #3392196: Exceptions in batch no longer are shown on the page when Javascript is disabled but we probably shouldn't wait on that

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork automatic_updates-3391715

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow opened merge request !967

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: Unassigned » phenaproxima
Status: Active » Needs review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes
Related issues: +#3392196: Exceptions in batch no longer are shown on the page when Javascript is disabled
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
Status: Needs review » Reviewed & tested by the community

If this passes, I think it looks good. No objections. We'll need to mention in the release notes that you have to run the command as php vendor/bin/auto-update.

  • tedbow committed e5f573b9 on 3.0.x 
    Issue #3391715: Change core merge request converter to either produce...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Reviewed & tested by the community » Fixed

@phenaproxima thanks for the reviews. I updated the change record https://www.drupal.org/node/3393723

tedbow opened merge request !974

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: Unassigned » tedbow
Status: Fixed » Active

Creating a new MR and re-opening the issue

Now that we have a fix for #3392196: Exceptions in batch no longer are shown on the page when Javascript is disabled that exposes that some of the tests that were failing for that will also fail once they get past that.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: tedbow » phenaproxima
Status: Active » Needs review

This gets all our functional tests passing on the core MR now that we have a temporary fix for #3392196: Exceptions in batch no longer are shown on the page when Javascript is disabled

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
Status: Needs review » Reviewed & tested by the community

Well, this looks good to me. If it passes tests, go ahead and merge it. No objection here.

  • tedbow committed f2516c47 on 3.0.x 
    Issue #3391715 by tedbow, phenaproxima: Change core merge request...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Closed (fixed) » Needs work

reopening to update the core merge request

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

Found the first problem https://git.drupalcode.org/issue/drupal-2977515/-/jobs/485380

I am working in scratch PR right now at #2977515: [ignore] Test Package manager core merge

---- Drupal\Tests\package_manager\Kernel\SymlinkValidatorTest ----
Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
Exception Other      phpunit-341.xml      0 Drupal\Tests\package_manager\Kernel
    PHPUnit Test failed to complete; Error: PHPUnit 9.6.15 by Sebastian
    Bergmann and contributors.
    
    Testing Drupal\Tests\package_manager\Kernel\SymlinkValidatorTest
    E.....E..                                                           9 / 9
    (100%)
    
    Time: 00:34.729, Memory: 4.00 MB
    
    There were 2 errors:
    
    1)
    Drupal\Tests\package_manager\Kernel\SymlinkValidatorTest::testSymlinksWithinSamePackage
    Drupal\Core\Extension\InfoParserException: Unable to parse
    core/profiles/demo_umami/demo_umami.info.yml as it does not exist
    
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/InfoParserDynamic.php:40
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/InfoParser.php:22
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:556
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:318
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:284
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:126
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:91
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:300
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:138
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:314
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:155
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:284
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:408
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:368
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:396
    /builds/issue/drupal-2977515/core/includes/update.inc:303
    /builds/issue/drupal-2977515/core/modules/package_manager/src/Validator/PendingUpdatesValidator.php:65
    /builds/issue/drupal-2977515/core/modules/package_manager/src/Validator/PendingUpdatesValidator.php:45
    /builds/issue/drupal-2977515/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:111
    /builds/issue/drupal-2977515/core/modules/package_manager/src/StatusCheckTrait.php:50
    /builds/issue/drupal-2977515/core/modules/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php:241
    /builds/issue/drupal-2977515/core/modules/package_manager/tests/src/Kernel/SymlinkValidatorTest.php:39
    /builds/issue/drupal-2977515/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
    
    2)
    Drupal\Tests\package_manager\Kernel\SymlinkValidatorTest::testSymlinkToDirectory
    with data set "rsync" ('rsync', array())
    Drupal\Core\Extension\InfoParserException: Unable to parse
    core/profiles/demo_umami/demo_umami.info.yml as it does not exist
    
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/InfoParserDynamic.php:40
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/InfoParser.php:22
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:556
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:318
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:284
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:126
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:91
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:300
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:138
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:314
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ModuleExtensionList.php:155
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:284
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:408
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:368
    /builds/issue/drupal-2977515/core/lib/Drupal/Core/Extension/ExtensionList.php:396
    /builds/issue/drupal-2977515/core/includes/update.inc:303
    /builds/issue/drupal-2977515/core/modules/package_manager/src/Validator/PendingUpdatesValidator.php:65
    /builds/issue/drupal-2977515/core/modules/package_manager/src/Validator/PendingUpdatesValidator.php:45
    /builds/issue/drupal-2977515/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:111
    /builds/issue/drupal-2977515/core/modules/package_manager/src/StatusCheckTrait.php:50
    /builds/issue/drupal-2977515/core/modules/package_manager/tests/src/Kernel/PackageManagerKernelTestBase.php:241
    /builds/issue/drupal-2977515/core/modules/package_manager/tests/src/Kernel/SymlinkValidatorTest.php:185
    /builds/issue/drupal-2977515/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

I have confirm this locally with the AU 3.0.x branch and core 11.x. So it is not a problem with the conversion to the core MR but with our compatiblity with 11.x.