Problem/Motivation

accessCheck() required on views plugin

without accessCheck(), views throw the following error:
Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Query\Sql\Query->prepare() (line 141 of /var/www/html/web/core/lib/Drupal/Core/Entity/Query/Sql/Query.php).

Steps to reproduce

Proposed resolution

see patch

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 moderation_team_accessCheck-3391498.patch653 bytessarwan_verma

Issue fork moderation_team-3391498

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kay_v created an issue. See original summary.

sarwan_verma’s picture

sarwan_verma commented
Assigned: Unassigned » sarwan_verma

kay_v opened merge request !3

kay_v’s picture

kay_v commented
Assigned: sarwan_verma » Unassigned
sarwan_verma’s picture

sarwan_verma commented
Status: Active » Needs review
StatusFileSize
new moderation_team_accessCheck-3391498.patch653 bytes

Hello @kay_v,
I have fixed this issue add accessCheck() to views plugin and also attached patch,
please review and verify.

kay_v closed merge request !3

kay_v opened merge request !4

kay_v’s picture

kay_v commented

hi @sarwan_verma - thanks for your surprisingly quick attention to this issue. I'd actually had a fix ready on my local when I filed the issue. Please feel free to have a look at the MR and add any comments. It looks quite different from your approach.

Interested in your thoughts.

kay_v opened merge request !5

kay_v closed merge request !5

sarwan_verma’s picture

sarwan_verma commented

Hi@kay_v,
Thanks in advance.

  • edysmp committed 7c0d3670 on 3.0.x authored by kay_v 
    Issue #3391498 by kay_v, sarwan_verma: add accessCheck() to views plugin
edysmp’s picture

edysmp
Primary language Spanish
Location Nicaragua
commented
Status: Needs review » Fixed

Committed and pushed to 3.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.