Problem/Motivation

This module depends on specific conditions for its operation:

When I used the module in its default state to place the "Sector Multipage Pagination block", the resulting block ID was "THEMENAME_sectormultipagepaginationblock" not "sectormultipagepaginationblock".

Steps to reproduce

Various, just keeping notes for now!

Proposed resolution

Move this to configuration?

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork sector_multipage-3391489

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xurizaemon created an issue. See original summary.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Title: Implementation is hardcoded to entity bundle and field name » Fixed entity bundle, field name, CSS class
Issue summary: View changes
xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Issue summary: View changes

xurizaemon opened merge request !6

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Title: Fixed entity bundle, field name, CSS class » Entity bundle, field name, CSS class should be less implementation specific

Re-titling because "fixed" can mean "hardcoded" or "solved" and I didn't mean the latter :)

ericgsmith made their first commit to this issue’s fork.

ericgsmith’s picture

ericgsmith commented
Status: Active » Needs review
ericgsmith’s picture

ericgsmith commented
Status: Needs review » Fixed

Resolved thread on original feedback - think the existings eslint issue is out of scope for this.

Test passes on D10 - this looks good to go

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.