Problem/Motivation

Hi, I suggest a small improvement to dark theme, set color-scheme: dark to .gin--dark-mode, this will create stylized scrollbars for dark theme in modern browsers :)

CommentFileSizeAuthor
#4 3391098-4-after.png62.6 KBshyam_bhatt
chrome.png16.57 KBkksandr

Issue fork gin-3391098

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kksandr created an issue. See original summary.

kksandr opened merge request !313

kksandr’s picture

kksandr commented
Status: Active » Needs review
shyam_bhatt’s picture

shyam_bhatt
he/him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3391098-4-after.png62.6 KB

@kksandr I have checked the "MR !313", looks good. After adding the "color-scheme: dark" property to ".gin--dark-mode" class, we can see a stylized scrollbar for dark themes in modern browsers.

For reference please check the "color-scheme" property https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme

After MR:
2023-10-04/3391098-4-after.png

Moving to +RTBC.

saschaeggi made their first commit to this issue’s fork.

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

That's a great enhancement, thank you for your contribution 👏

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.