In admin/content/types -> Locative information -> Collection settings, the drag and drop of fields have no effect.

Files: 
CommentFileSizeAuthor
#16 tabledrag_js_16.patch1.96 KBq0rban
Failed: Failed to apply patch.
[ View ]
#10 jquery_update_tabledrag.patch39.4 KBq0rban
Failed: Failed to apply patch.
[ View ]
#9 jquery_update_tabledrag.patch39.38 KBq0rban
Failed: Failed to apply patch.
[ View ]
#7 tabledrag.js_.patch937 bytesbdragon
Failed: Failed to apply patch.
[ View ]
#1 Picture 7.png81.86 KBdrewish

Comments

drewish’s picture

StatusFileSize
new81.86 KB

Yeah and the weights are showing up. It looks like somethings kind of screwy. see the attached image.

bdragon’s picture

Status:Active» Fixed

Drag and drop was fixed just before the 3.0 release. (Two seperate bugs were preventing it from working properly.)

re: drewish's issue: I'm guessing a JS failure somewhere? I can't reproduce..

drewish’s picture

Seen that on two sites and no JS errors according to firebug.

bdragon’s picture

What release of Drupal 6? Perhaps something changed with the weight fields somewhere along the line... The javascript is supposed to hide the weight field....

bdragon’s picture

Title:Collection settings' drag and drop not working» Weight fields shown in D6.8
Status:Fixed» Active

Reopening because I was able to reproduce on a test site running a newer Drupal. I had been testing against 6.6.

bdragon’s picture

DOH! I had a local mod to work around a core bug, and totally forgot about it!

bdragon’s picture

StatusFileSize
new937 bytes
Failed: Failed to apply patch.
[ View ]

Here's the core patch I've been running on.

The problem is that tabledrag.js malfunctions if the tabledrag is inside a collapsible fieldset, because it checks whether an element is hidden already before hiding it, and the way it checks considers it "hidden" if it's just inside a collapsed fieldset.

This should get fixed in core I guess.

q0rban’s picture

I see this also on multiple filefields inside of a collapsed fieldset. Perhaps this could be fixed with jquery update by changing this to a feature request for that project.

q0rban’s picture

Title:Weight fields shown in D6.8» Fix tabledrag inside fieldsets
Project:Location» jQuery Update
Version:6.x-3.x-dev» 6.x-1.1
Category:bug» feature
Status:Active» Needs review
StatusFileSize
new39.38 KB
Failed: Failed to apply patch.
[ View ]

Moving this over to jquery_update and attaching a patch. jQuery Update will only override the file if you have the settings to something other than 'Packed' or are using a jQuery version greater than the one that ships with d6.x.

To describe the problem for the jquery_update maintainers, if you have tabledrag elements inside of a collapsed fieldset, the tabledrag js breaks and doesn't hide the weight fields or add the handles.

q0rban’s picture

StatusFileSize
new39.4 KB
Failed: Failed to apply patch.
[ View ]

Whoops, just noticed I put the tabledrag.js in the wrong folder.

mfer’s picture

Project:jQuery Update» Drupal core
Version:6.x-1.1» 7.x-dev
Component:Code» javascript
Status:Needs review» Needs work

I added this to the drupal 6 jQuery Update 1.x dev branch. I would really like this to be tested some more before I release it. I did some quick tests in IE6/7, FF, Safari, and Chrome and didn't find any problems. Is there a reason it was not applied to hidden areas in the past?

This is really an issue that should be fixed in drupal core so I am moving it there.

mfer’s picture

Issue tags:+JavaScript

adding javascript tag

mfer’s picture

Status:Needs work» Postponed (maintainer needs more info)

Now that I look at this, why does tabledrag work for the upload module in a fieldset and not Location?

mfer’s picture

Spoke with q0rban and in the case of the upload module it works because that fieldset is always open when there are files in there or being added. If it is forced to be closed the tabledrag is never attached to these.

I'm not sure the implementation suggested in these patches is a good idea. There is potential, though unlikely, for it to explode on some hidden content in a page. I wonder if attaching the tabledrag behavior to a fieldset when it is initially opened would be a better idea.

q0rban’s picture

Title:Fix tabledrag inside fieldsets» Tabledrag not hiding columns inside collapsed fieldsets
Category:feature» bug
Status:Postponed (maintainer needs more info)» Needs work

Switching back to a bug report and updating the title. The current patch breaks on menu administration (ie, admin/build/menu-customize/navigation), as it removes the 'Enabled' column header.

q0rban’s picture

Status:Needs work» Needs review
StatusFileSize
new1.96 KB
Failed: Failed to apply patch.
[ View ]

Safari now honors display:none on th, so switching to that fixed the above issue.

Status:Needs review» Needs work

The last submitted patch failed testing.

Kars-T’s picture

--- tabledrag.js 27 Apr 2009 20:19:35 -0000 1.28
+++ tabledrag.js 27 May 2009 19:27:36 -0000

Please change these lines to

--- misc/tabledrag.js 27 Apr 2009 20:19:35 -0000 1.28
+++ misc/tabledrag.js 27 May 2009 19:27:36 -0000

and auto testing should succeed. Otherwise HEAD did change a lot and I can't apply and test your patch manually.

This review is powered by Dreditor.

udig’s picture

#425148: Form elements within a collapsed field group are not visible in Internet Explorer was marked as duplicate for this issue.
Is it?
The symptoms mentioned here seems to be different then these mentioned over there.

?

q0rban’s picture

Status:Needs work» Closed (duplicate)