highlightField() returns wrong outputWhen input is:
<a href="/education/glossary/investment-underwriting-agreement" hreflang="pl">investment underwriting agreement</a>
it produces output like this:
<a href="/education/glossary/investment-underwriting-<strong>agreement</strong>" hreflang="pl">investment underwriting <strong>agreement</strong>
https://onlinephp.io/c/4e103
See also this comment https://www.drupal.org/project/search_api/issues/3264239#comment-15129743
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3390450-5--highlight_processor_html_attributes.patch | 2.59 KB | drunken monkey |
Comments
Comment #2
jlukasie commentedComment #3
drunken monkeyThanks a lot for reporting this problem.
I could reproduce it, and writing a regression test for it is also pretty simple, see attached.
However, I cannot really see where the regular expression goes wrong. Do you have a proposed fix for this problem, a regular expression that actually matched complete HTML tags even if they have attributes with values?
Comment #5
drunken monkeyMaybe just simplify the tag contents expression instead of trying to match individual attributes? I guess we used the current regular expression to avoid problems in case of invalid HTML, but should hopefully be a minor problem at this point.
Comment #6
jlukasie commentedThanks, I think You are right. The simpler expression is the better for future maintenance.
Invalid HTML should be no big problem at the moment.
Comment #8
drunken monkeyThanks for the feedback!
Committed.