Problem/Motivation

The existing classes used are a result or working fast on a prototype and make component definition and location complicated. Also, in the #3386927: [PLAN] Refactor CSS there's a lot of work and we need to break it down.
Also, there are other classes that aren't following a BEM structure.

Proposed resolution

In #3387374: Change main components naming we defined some classes for the main components, as described in #3386927: [PLAN] Refactor CSS. Let's do this changes here, plus refactor other class not following a BEM structure.

Issue fork navigation-3390406

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ckrina created an issue. See original summary.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Issue summary: View changes
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Assigned: Unassigned » ckrina
claireristow’s picture

claireristow commented
Assigned: ckrina » claireristow

Working on this now

claireristow opened merge request !74

claireristow’s picture

claireristow commented
Assigned: claireristow » Unassigned
Status: Active » Needs review
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community

Nice! Good to go!

PD. We just found a weird behavior that moves the content creation menu at the bottom already happening on the main branch, so @claireristow is going to open a follow-up for this.

claireristow’s picture

claireristow commented
Status: Reviewed & tested by the community » Fixed

Just created a new issue for that menu ordering bug here: https://www.drupal.org/project/navigation/issues/3390478

Merging these changes!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.